From: Andrew Burgess <aburgess@redhat.com>
To: Soham Gargote <sgargote@whileone.in>,
gdb-patches@sourceware.org, binutils@sourceware.org
Cc: Soham Gargote <sgargote@whileone.in>, Sameer Natu <snatu@whileone.in>
Subject: Re: [PATCH] Set rv64gcv as default to enable vector extension for disassembly
Date: Wed, 30 Jul 2025 13:27:23 +0100 [thread overview]
Message-ID: <87a54ldftg.fsf@redhat.com> (raw)
In-Reply-To: <20250723104034.2324-2-sgargote@whileone.in>
Hi!
Thanks for working on this. Patches to the opcodes/ directory need to
be reviewed on the binutils@sourceware.org list (Added to the To: list).
From the GDB side, I have no problems with this change, but I cannot
approve it.
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
Thanks,
Andrew
Soham Gargote <sgargote@whileone.in> writes:
> Co-Authored-By: Sameer Natu <snatu@whileone.in>
>
> ---
> opcodes/riscv-dis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
> index f6af9c47a25..a67b51bad74 100644
> --- a/opcodes/riscv-dis.c
> +++ b/opcodes/riscv-dis.c
> @@ -1444,7 +1444,7 @@ riscv_init_disasm_info (struct disassemble_info *info)
> pd->riscv_rps_dis.xlen = &pd->xlen;
> pd->riscv_rps_dis.isa_spec = &pd->default_isa_spec;
> pd->riscv_rps_dis.check_unknown_prefixed_ext = false;
> - pd->default_arch = "rv64gc";
> + pd->default_arch = "rv64gcv";
> if (info->section != NULL)
> {
> bfd *abfd = info->section->owner;
> --
> 2.48.1
next prev parent reply other threads:[~2025-07-30 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 10:40 Soham Gargote
2025-07-30 12:27 ` Andrew Burgess [this message]
2025-07-30 13:07 ` Andreas Schwab
2025-07-31 2:37 ` Nelson Chu
2025-07-31 7:21 ` Charlie Jenkins
2025-07-31 7:33 ` Jan Beulich
2025-07-31 10:32 ` Nelson Chu
-- strict thread matches above, loose matches on Subject: below --
2025-07-22 10:34 Soham Gargote
2025-07-22 19:42 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a54ldftg.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=sgargote@whileone.in \
--cc=snatu@whileone.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox