Re: [PATCH v2] gdb/jit: add function symbols to global block

[Tom Tromey <tom@tromey.com>]

>>>>> "Jan" == Jan Vrany <jan.vrany@labware.com> writes:

Jan> +	{
Jan> +	  new_block = new (&objfile->objfile_obstack) global_block;
Jan> +	  new_block->set_multidict (
Jan> +	    mdict_create_linear (&objfile->objfile_obstack, global_symbols));
Jan> +	}
Jan>        else
Jan> -	new_block = new (&objfile->objfile_obstack) block;
Jan> +	{
Jan> +	  new_block = new (&objfile->objfile_obstack) block;
Jan> +	  new_block->set_multidict (
Jan> +	    mdict_create_linear (&objfile->objfile_obstack, {}));
Jan> +	}

Does anything ever get added to the static block?
If not then making a dictionary doesn't seem necessary?

Also the formatting is wonky here, that "(" should not be at the end of
the line.  (Two instances of this.)

Kind of weird that this code doesn't use buildsym, but OTOH buildsym is
horrible.

Tom