From: Tom Tromey <tom@tromey.com>
To: "Jan Vraný" <Jan.Vrany@labware.com>
Cc: "tom@tromey.com" <tom@tromey.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] gdb/jit: add function symbols to global block
Date: Tue, 13 Jan 2026 15:47:25 -0700 [thread overview]
Message-ID: <87pl7dgmf6.fsf@tromey.com> (raw)
In-Reply-To: <79227e4c024aad95b42c70022093c917ace6f6dd.camel@labware.com> ("Jan =?utf-8?Q?Vran=C3=BD=22's?= message of "Tue, 13 Jan 2026 21:42:51 +0000")
>>>>> "Jan" == Jan Vraný <Jan.Vrany@labware.com> writes:
>> If not then making a dictionary doesn't seem necessary?
Jan> As the code stands now, I think it has to - the rest of code expects it is
Jan> always there. For example, blockvector::~blockvector() just unconditionally
Jan> frees the dictionary. Or blpy_repr() that calls mdict_size().
Gotcha, thanks for looking.
Maybe at someday we should let mdict_free take a null pointer and
then we could omit empty dictionaries for some blocks.
Tom
next prev parent reply other threads:[~2026-01-13 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 18:15 Jan Vrany
2026-01-13 16:20 ` Tom Tromey
2026-01-13 21:42 ` Jan Vraný
2026-01-13 22:47 ` Tom Tromey [this message]
2026-01-14 10:44 ` [PATCH v3] " Jan Vrany
2026-01-14 13:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl7dgmf6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Jan.Vrany@labware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox