From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jDqNNw9xZmlKggEAWB0awg (envelope-from ) for ; Tue, 13 Jan 2026 11:21:35 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=q9I5E10V; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D47A01E070; Tue, 13 Jan 2026 11:21:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A7421E070 for ; Tue, 13 Jan 2026 11:21:35 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A483E4BA2E25 for ; Tue, 13 Jan 2026 16:21:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A483E4BA2E25 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=q9I5E10V Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id B87A94BA2E28 for ; Tue, 13 Jan 2026 16:20:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B87A94BA2E28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B87A94BA2E28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768321247; cv=none; b=vUBznVPt6SFwQkZShwzYb1/+dbYCG1EPsc4QWqeTqhF1q6P9KoxxDxu9igz7vCSWiKq+VGf0XsIzHzw0Vvqj4CY2/4HdeODs3/xR3X3AV52pRjVaJEaMLpFM5uMXtz1Fwuo81M2qVL27Nixhqdu2PEuzAi+lJ8J4SnAtpa1jCU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768321247; c=relaxed/simple; bh=uEERHXuahWBKsWq76WOBGl8F37YDkfyaRcjhrur1v/k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Z/p6F4zp1fk6tPGGOWxqqwcAI2IRAuo6/q9hb4DDq3yyX6cEWIisWgheFO5/1OHtWYyrYgSvbIuhoq7xlNzxFsdplwLnyyitrQvdgq2mWuBLYNUCmcmKux3XlFf30JUbNdXZqK9zxqirLRdOiiw7CsLXebxddm3/UgvnRLvt9gM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B87A94BA2E28 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id fh82vNHxYaPqLfh8QvY1LH; Tue, 13 Jan 2026 16:20:46 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id fh8QvWvh0cu11fh8Qvzl88; Tue, 13 Jan 2026 16:20:46 +0000 X-Authority-Analysis: v=2.4 cv=bKYWIO+Z c=1 sm=1 tr=0 ts=696670de a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=TDl5R864AAAA:8 a=L6LuLe7nZOEH4LUFQT4A:9 a=4IKI_MBedZsHOhguCAbN:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xdQgKewIPBusQnN7Zysu0XjSUJZWeWwF553ovjq6RjA=; b=q9I5E10VYWmT1huAdJTsNMxSsJ HAcWWt/6oR7yvBSxGTZg7Otjz4knM6X42g4B6do2Wxxm/WluDyLUQXjlNWPd4Y8SfmYi031nEzUfh ig3OULC1qroIGRcntlhxTtRLb; Received: from 75-166-246-134.hlrn.qwest.net ([75.166.246.134]:41166 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vfh8P-00000000rz8-3zw3; Tue, 13 Jan 2026 09:20:46 -0700 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb/jit: add function symbols to global block In-Reply-To: <20260106181539.154125-1-jan.vrany@labware.com> (Jan Vrany's message of "Tue, 6 Jan 2026 18:15:39 +0000") References: <20260106181539.154125-1-jan.vrany@labware.com> X-Attribution: Tom Date: Tue, 13 Jan 2026 09:20:44 -0700 Message-ID: <87a4yhjxgj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.246.134 X-Source-L: No X-Exim-ID: 1vfh8P-00000000rz8-3zw3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-246-134.hlrn.qwest.net (bapiya) [75.166.246.134]:41166 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAwWN5icif4tPwSOVT3GVdSHpFa6CfcBG7k7ypluayNnino/PSo1wEqyjV8jjvZafyb0eqwM97zwxWPo+2yDRvwZn7BLTxlP5xmrNKjLx4VPrhlp2zr+ hd3E3195T3bRKwv1U4D0kezWuJY76REbsyko7CyYxK0oRqdQtV7Slq8YTzxInaXy1d2RLAE2azRnYl/ZNNqsH9inEj+jT5mphPE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" == Jan Vrany writes: Jan> + { Jan> + new_block = new (&objfile->objfile_obstack) global_block; Jan> + new_block->set_multidict ( Jan> + mdict_create_linear (&objfile->objfile_obstack, global_symbols)); Jan> + } Jan> else Jan> - new_block = new (&objfile->objfile_obstack) block; Jan> + { Jan> + new_block = new (&objfile->objfile_obstack) block; Jan> + new_block->set_multidict ( Jan> + mdict_create_linear (&objfile->objfile_obstack, {})); Jan> + } Does anything ever get added to the static block? If not then making a dictionary doesn't seem necessary? Also the formatting is wonky here, that "(" should not be at the end of the line. (Two instances of this.) Kind of weird that this code doesn't use buildsym, but OTOH buildsym is horrible. Tom