From: Tom Tromey <tromey@redhat.com>
To: Roland Schwingel <roland@onevision.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add dll trampoline code handling for windows 64bit
Date: Wed, 14 Mar 2012 15:34:00 -0000 [thread overview]
Message-ID: <878vj3dwnn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F609EB7.2020801@onevision.com> (Roland Schwingel's message of "Wed, 14 Mar 2012 14:35:51 +0100")
>>>>> "Roland" == Roland Schwingel <roland@onevision.com> writes:
Roland> - The jump destination is on 64bit windows of course 8 byte
Roland> long. I could not find a function that transforms this into a
Roland> CORE_ADDR like read_memory_unsigned_integer() it is doing in the
Roland> 32bit case. So I did the transformation on my own. While this
Roland> is high performant it might not be the "official" gdb way. If
Roland> someone can give me a hint on how to the transformation the
Roland> "official" way I will adjust my patch - if wished.
Just use read_memory_unsigned_integer.
I think it is guaranteed that CORE_ADDR will not be larger than
ULONGEST.
I can't really comment on the rest of your patch.
I think it is big enough that it requires a copyright assignment.
If you don't have one, contact me off-list to get started.
Tom
next prev parent reply other threads:[~2012-03-14 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 13:36 Roland Schwingel
2012-03-14 15:34 ` Tom Tromey [this message]
2012-03-14 16:13 ` Joel Brobecker
2012-03-15 14:57 ` [PATCH v2] " Roland Schwingel
2012-03-15 15:38 ` Tom Tromey
2012-03-14 20:38 [PATCH] " Roland Schwingel
2012-03-14 21:03 ` Joel Brobecker
2012-03-14 23:54 ` Stan Shebs
2012-03-15 14:27 ` Tom Tromey
2012-03-15 15:26 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vj3dwnn.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=roland@onevision.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox