From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4924 invoked by alias); 14 Mar 2012 15:34:34 -0000 Received: (qmail 4876 invoked by uid 22791); 14 Mar 2012 15:34:33 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Mar 2012 15:34:18 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2EFY69t001717 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 14 Mar 2012 11:34:06 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2EFY4lZ021578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 14 Mar 2012 11:34:05 -0400 From: Tom Tromey To: Roland Schwingel Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add dll trampoline code handling for windows 64bit References: <4F609EB7.2020801@onevision.com> Date: Wed, 14 Mar 2012 15:34:00 -0000 In-Reply-To: <4F609EB7.2020801@onevision.com> (Roland Schwingel's message of "Wed, 14 Mar 2012 14:35:51 +0100") Message-ID: <878vj3dwnn.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00482.txt.bz2 >>>>> "Roland" == Roland Schwingel writes: Roland> - The jump destination is on 64bit windows of course 8 byte Roland> long. I could not find a function that transforms this into a Roland> CORE_ADDR like read_memory_unsigned_integer() it is doing in the Roland> 32bit case. So I did the transformation on my own. While this Roland> is high performant it might not be the "official" gdb way. If Roland> someone can give me a hint on how to the transformation the Roland> "official" way I will adjust my patch - if wished. Just use read_memory_unsigned_integer. I think it is guaranteed that CORE_ADDR will not be larger than ULONGEST. I can't really comment on the rest of your patch. I think it is big enough that it requires a copyright assignment. If you don't have one, contact me off-list to get started. Tom