From: Tom Tromey <tromey@redhat.com>
To: Roland Schwingel <roland@onevision.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Add dll trampoline code handling for windows 64bit
Date: Thu, 15 Mar 2012 15:38:00 -0000 [thread overview]
Message-ID: <878vj1dgd3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F62032B.3000907@onevision.com> (Roland Schwingel's message of "Thu, 15 Mar 2012 15:56:43 +0100")
>>>>> "Roland" == Roland Schwingel <roland@onevision.com> writes:
Roland> Here is a new version of my patch from yesterday. I took
Roland> (hopefully correct) all suggestions regarding formatting and
Roland> indention into account.
It seems ok to me.
Roland> I can't use the gdb read_memory functions here that do
Roland> endianness conversion.
Kai Tietz read this patch -- he says "hello" and asked me to respond.
Roland> + struct minimal_symbol *indsym =
Roland> + indirect ? lookup_minimal_symbol_by_pc (pc + indirect) : 0;
Kai says that PC-relative expressions are relative to the end of the
instruction. So, 'pc + indirect' is incorrect here and also in the
read_memory call.
Tom
prev parent reply other threads:[~2012-03-15 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 13:36 [PATCH] " Roland Schwingel
2012-03-14 15:34 ` Tom Tromey
2012-03-14 16:13 ` Joel Brobecker
2012-03-15 14:57 ` [PATCH v2] " Roland Schwingel
2012-03-15 15:38 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vj1dgd3.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=roland@onevision.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox