From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3757 invoked by alias); 15 Mar 2012 15:38:43 -0000 Received: (qmail 3742 invoked by uid 22791); 15 Mar 2012 15:38:42 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Mar 2012 15:38:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2FFcHha029479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 15 Mar 2012 11:38:17 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2FFcGX7016066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 15 Mar 2012 11:38:16 -0400 From: Tom Tromey To: Roland Schwingel Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Add dll trampoline code handling for windows 64bit References: <4F609EB7.2020801@onevision.com> <4F62032B.3000907@onevision.com> Date: Thu, 15 Mar 2012 15:38:00 -0000 In-Reply-To: <4F62032B.3000907@onevision.com> (Roland Schwingel's message of "Thu, 15 Mar 2012 15:56:43 +0100") Message-ID: <878vj1dgd3.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00542.txt.bz2 >>>>> "Roland" == Roland Schwingel writes: Roland> Here is a new version of my patch from yesterday. I took Roland> (hopefully correct) all suggestions regarding formatting and Roland> indention into account. It seems ok to me. Roland> I can't use the gdb read_memory functions here that do Roland> endianness conversion. Kai Tietz read this patch -- he says "hello" and asked me to respond. Roland> + struct minimal_symbol *indsym = Roland> + indirect ? lookup_minimal_symbol_by_pc (pc + indirect) : 0; Kai says that PC-relative expressions are relative to the end of the instruction. So, 'pc + indirect' is incorrect here and also in the read_memory call. Tom