Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550
Date: Tue, 18 Sep 2012 19:37:00 -0000	[thread overview]
Message-ID: <878vc7w2al.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1347942847-31510-2-git-send-email-sanjoy@playingwithpointers.com>	(Sanjoy Das's message of "Tue, 18 Sep 2012 10:04:05 +0530")

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> +	  /* If the plugin specifically mentioned a parent block, we
Sanjoy> +	     use that */

The comment should end with a period and two spaces.

Sanjoy> +	  /* and if not, we set a default parent block. */

Similarly, and also the first letter should be capitalized.

Ok with those changes.

Tom


  reply	other threads:[~2012-09-18 19:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18  4:30 [PATCH 0/3] Fix recent breakage in the JIT reader interface Sanjoy Das
2012-09-18  4:30 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-09-18 19:36   ` Tom Tromey
2012-09-18  4:30 ` [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects Sanjoy Das
2012-09-18  6:59   ` Eli Zaretskii
2012-09-18 19:21     ` Tom Tromey
2012-09-18  4:30 ` [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550 Sanjoy Das
2012-09-18 19:37   ` Tom Tromey [this message]
2012-09-24  4:48 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-09-24  4:48 ` [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550 Sanjoy Das
2012-09-24  8:12   ` Joel Brobecker
2012-09-27 20:59   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vc7w2al.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sanjoy@playingwithpointers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox