From: Eli Zaretskii <eliz@gnu.org>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org, sanjoy@playingwithpointers.com
Subject: Re: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects.
Date: Tue, 18 Sep 2012 06:59:00 -0000 [thread overview]
Message-ID: <83obl324vf.fsf@gnu.org> (raw)
In-Reply-To: <1347942847-31510-3-git-send-email-sanjoy@playingwithpointers.com>
> From: Sanjoy Das <sanjoy@playingwithpointers.com>
> Cc: Sanjoy Das <sanjoy@playingwithpointers.com>
> Date: Tue, 18 Sep 2012 10:04:06 +0530
>
> +@item jit-reader-load @var{reader}
> +Load the JIT reader named @var{reader}. @var{reader} can either be
> +the absolute path to or the file name of a shared object.
GNU coding standards discourage using "path" to mean a file name. So
I suggest to rephrase:
@var{reader} is a shared object specified as either an absolute or
a relative file name.
> +Only one reader can be active at a time; trying to load a second
> +reader when one is already loaded will result in @value{GDBN}
> +reporting an error. A new JIT reader can be loaded by first unloading
> +the current one using @code{jit-reader-load} and then invoking
> +@code{jit-reader-load}. ^^^^^^^^^^^^^^^
"jit-reader-unload", I presume. (Yes, I know you were only copying
the existing mistake.)
The documentation parts are OK with those changes.
> + if (args[0] == '/')
Why not use IS_ABSOLUTE_PATH here? That would make the code more
portable.
Thanks.
next prev parent reply other threads:[~2012-09-18 6:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 4:30 [PATCH 0/3] Fix recent breakage in the JIT reader interface Sanjoy Das
2012-09-18 4:30 ` [PATCH 3/3] Add a test case for the jit-reader interface Sanjoy Das
2012-09-18 19:36 ` Tom Tromey
2012-09-18 4:30 ` [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects Sanjoy Das
2012-09-18 6:59 ` Eli Zaretskii [this message]
2012-09-18 19:21 ` Tom Tromey
2012-09-18 4:30 ` [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550 Sanjoy Das
2012-09-18 19:37 ` Tom Tromey
2012-09-24 4:48 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-09-24 4:48 ` [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects Sanjoy Das
2012-09-24 5:45 ` Eli Zaretskii
2012-09-27 20:58 ` Tom Tromey
2012-10-08 11:43 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-10-08 11:43 ` [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects Sanjoy Das
2012-10-08 12:34 ` Eli Zaretskii
2012-10-16 20:13 ` Tom Tromey
2012-11-04 16:59 [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface" Sanjoy Das
2012-11-04 17:00 ` [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects Sanjoy Das
2013-01-09 9:36 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83obl324vf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=sanjoy@playingwithpointers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox