From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94621-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18606 invoked by alias); 18 Sep 2012 06:59:49 -0000
Received: (qmail 18586 invoked by uid 22791); 18 Sep 2012 06:59:48 -0000
X-SWARE-Spam-Status: No, hits=-4.1 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 06:59:25 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MAJ00E00A217200@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 18 Sep 2012 09:59:24 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAJ00D7LA2ZZ690@a-mtaout22.012.net.il>; Tue, 18 Sep 2012 09:59:24 +0300 (IDT)
Date: Tue, 18 Sep 2012 06:59:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects.
In-reply-to: <1347942847-31510-3-git-send-email-sanjoy@playingwithpointers.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org, sanjoy@playingwithpointers.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83obl324vf.fsf@gnu.org>
References: <1347942847-31510-1-git-send-email-sanjoy@playingwithpointers.com> <1347942847-31510-3-git-send-email-sanjoy@playingwithpointers.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00344.txt.bz2

> From: Sanjoy Das <sanjoy@playingwithpointers.com>
> Cc: Sanjoy Das <sanjoy@playingwithpointers.com>
> Date: Tue, 18 Sep 2012 10:04:06 +0530
> 
> +@item jit-reader-load @var{reader}
> +Load the JIT reader named @var{reader}.  @var{reader} can either be
> +the absolute path to or the file name of a shared object.

GNU coding standards discourage using "path" to mean a file name.  So
I suggest to rephrase:

 @var{reader} is a shared object specified as either an absolute or
 a relative file name.

> +Only one reader can be active at a time; trying to load a second
> +reader when one is already loaded will result in @value{GDBN}
> +reporting an error.  A new JIT reader can be loaded by first unloading
> +the current one using @code{jit-reader-load} and then invoking
> +@code{jit-reader-load}.     ^^^^^^^^^^^^^^^

"jit-reader-unload", I presume.  (Yes, I know you were only copying
the existing mistake.)

The documentation parts are OK with those changes.

> +  if (args[0] == '/')

Why not use IS_ABSOLUTE_PATH here?  That would make the code more
portable.

Thanks.