From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94654-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14217 invoked by alias); 18 Sep 2012 19:37:24 -0000
Received: (qmail 14209 invoked by uid 22791); 18 Sep 2012 19:37:23 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 19:37:09 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8IJb7a2021247	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 18 Sep 2012 15:37:07 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8IJb6f9023001	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 18 Sep 2012 15:37:07 -0400
From: Tom Tromey <tromey@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550
References: <1347942847-31510-1-git-send-email-sanjoy@playingwithpointers.com>	<1347942847-31510-2-git-send-email-sanjoy@playingwithpointers.com>
Date: Tue, 18 Sep 2012 19:37:00 -0000
In-Reply-To: <1347942847-31510-2-git-send-email-sanjoy@playingwithpointers.com>	(Sanjoy Das's message of "Tue, 18 Sep 2012 10:04:05 +0530")
Message-ID: <878vc7w2al.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00377.txt.bz2

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> +	  /* If the plugin specifically mentioned a parent block, we
Sanjoy> +	     use that */

The comment should end with a period and two spaces.

Sanjoy> +	  /* and if not, we set a default parent block. */

Similarly, and also the first letter should be capitalized.

Ok with those changes.

Tom