* Re: [RFA] contrib/ari: Avoid permission issue for script [not found] <11045.9555559375$1351807023@news.gmane.org> @ 2012-11-02 17:27 ` Tom Tromey 2012-11-02 17:31 ` Pedro Alves ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Tom Tromey @ 2012-11-02 17:27 UTC (permalink / raw) To: Pierre Muller; +Cc: gdb-patches >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes: Pierre> But I still have the problem of the permissions Pierre> of the script files... Pierre> And I still don't know if (and if yes, how) Pierre> I can set file permissions in the CVS repository... You had to set them before 'cvs add'. I think we can chmod them in the repository but I don't remember whether that will fix people's existing checkouts when they update. Pierre> I can lift the problem for the main script, Pierre> by calling it using: Pierre> sh ../../src/gdb/contrib/ari/ create-web-ari-in-src.sh, Pierre> but this script calls update-web-ari.sh script Pierre> without using '. script'... I think you probably want $SHELL rather than '.' here. '.' runs it in the current shell, but the previous code launched a new shell. Pierre> Should I add myself as contrib/ari maintainer? Sure. Tom ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFA] contrib/ari: Avoid permission issue for script 2012-11-02 17:27 ` [RFA] contrib/ari: Avoid permission issue for script Tom Tromey @ 2012-11-02 17:31 ` Pedro Alves 2012-11-02 18:25 ` Pierre Muller 2012-11-05 11:06 ` [RFA-v2] " Pierre Muller [not found] ` <11663.278603419$1352113627@news.gmane.org> 2 siblings, 1 reply; 8+ messages in thread From: Pedro Alves @ 2012-11-02 17:31 UTC (permalink / raw) To: Tom Tromey; +Cc: Pierre Muller, gdb-patches On 11/02/2012 05:27 PM, Tom Tromey wrote: >>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes: > > Pierre> But I still have the problem of the permissions > Pierre> of the script files... > Pierre> And I still don't know if (and if yes, how) > Pierre> I can set file permissions in the CVS repository... > > You had to set them before 'cvs add'. > > I think we can chmod them in the repository but I don't remember whether > that will fix people's existing checkouts when they update. I think that might cause problems to the git mirror(s). I don't think we lose any history if we just cvs rm, chmod, cvs add the file again. There hasn't been any change to it in the mean time. -- Pedro Alves ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFA] contrib/ari: Avoid permission issue for script 2012-11-02 17:31 ` Pedro Alves @ 2012-11-02 18:25 ` Pierre Muller 2012-11-02 18:33 ` Pedro Alves 0 siblings, 1 reply; 8+ messages in thread From: Pierre Muller @ 2012-11-02 18:25 UTC (permalink / raw) To: 'Pedro Alves', 'Tom Tromey'; +Cc: gdb-patches Pedro, I did as you said I made those commits without changing the ChangeLog file. But I am afraid it doesn't work: I tried to delete all .sh scripts in an anonymous checkout in gdb/contrib/ari followed by a 'cvs up' This restored the files, but the files modes are still rw-r--r-- while I re-added them with rwx-r-xr-x permissions... Pierre Muller > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoyé : vendredi 2 novembre 2012 18:31 > À : Tom Tromey > Cc : Pierre Muller; gdb-patches@sourceware.org > Objet : Re: [RFA] contrib/ari: Avoid permission issue for script > > On 11/02/2012 05:27 PM, Tom Tromey wrote: > >>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes: > > > > Pierre> But I still have the problem of the permissions > > Pierre> of the script files... > > Pierre> And I still don't know if (and if yes, how) > > Pierre> I can set file permissions in the CVS repository... > > > > You had to set them before 'cvs add'. > > > > I think we can chmod them in the repository but I don't remember whether > > that will fix people's existing checkouts when they update. > > I think that might cause problems to the git mirror(s). I don't think > we lose any history if we just cvs rm, chmod, cvs add the file again. > There hasn't been any change to it in the mean time. > > -- > Pedro Alves ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFA] contrib/ari: Avoid permission issue for script 2012-11-02 18:25 ` Pierre Muller @ 2012-11-02 18:33 ` Pedro Alves 2012-11-02 18:44 ` Andreas Schwab 0 siblings, 1 reply; 8+ messages in thread From: Pedro Alves @ 2012-11-02 18:33 UTC (permalink / raw) To: Pierre Muller; +Cc: 'Tom Tromey', gdb-patches On 11/02/2012 06:25 PM, Pierre Muller wrote: > Pedro, > I did as you said > I made those commits without changing the ChangeLog file. > > But I am afraid it doesn't work: > I tried to delete all .sh scripts in an anonymous checkout > in gdb/contrib/ari > followed by a 'cvs up' > > This restored the files, but the files modes are still rw-r--r-- > while I re-added them with rwx-r-xr-x permissions... Bummer, I misremembered as this having worked before. Sorry about that. This thread points at a previous attempt that ended up in the same conclusion as yours: (seems like it works for some servers,clients,whoknows, not for others) http://sourceware.org/ml/binutils/2010-02/msg00499.html Eventually, the git mirror fix seems to have been easy: http://sourceware.org/ml/binutils/2010-02/msg00514.html -- Pedro Alves ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFA] contrib/ari: Avoid permission issue for script 2012-11-02 18:33 ` Pedro Alves @ 2012-11-02 18:44 ` Andreas Schwab 0 siblings, 0 replies; 8+ messages in thread From: Andreas Schwab @ 2012-11-02 18:44 UTC (permalink / raw) To: Pedro Alves; +Cc: Pierre Muller, 'Tom Tromey', gdb-patches Pedro Alves <palves@redhat.com> writes: > Eventually, the git mirror fix seems to have been easy: > > http://sourceware.org/ml/binutils/2010-02/msg00514.html It should also fix itself the next time the file is modified. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFA-v2] contrib/ari: Avoid permission issue for script 2012-11-02 17:27 ` [RFA] contrib/ari: Avoid permission issue for script Tom Tromey 2012-11-02 17:31 ` Pedro Alves @ 2012-11-05 11:06 ` Pierre Muller [not found] ` <11663.278603419$1352113627@news.gmane.org> 2 siblings, 0 replies; 8+ messages in thread From: Pierre Muller @ 2012-11-05 11:06 UTC (permalink / raw) To: 'Tom Tromey'; +Cc: gdb-patches > Pierre> I can lift the problem for the main script, > Pierre> by calling it using: > Pierre> sh ../../src/gdb/contrib/ari/ create-web-ari-in-src.sh, > Pierre> but this script calls update-web-ari.sh script > Pierre> without using '. script'... > > I think you probably want $SHELL rather than '.' here. > '.' runs it in the current shell, but the previous code launched a new > shell. You are right of course. Here is a new version of the patch. > Pierre> Should I add myself as contrib/ari maintainer? > > Sure. Submitted as a seperate thread. ChangeLog entry: 2012-11-05 Pierre Muller <muller@sourceware.org> * contrib/ari/create-web-ari-in-src.sh: Avoid problem if script is not executable. Index: create-web-ari-in-src.sh =================================================================== RCS file: /cvs/src/src/gdb/contrib/ari/create-web-ari-in-src.sh,v retrieving revision 1.3 diff -u -r1.3 create-web-ari-in-src.sh --- create-web-ari-in-src.sh 2 Nov 2012 18:19:36 -0000 1.3 +++ create-web-ari-in-src.sh 5 Nov 2012 11:03:29 -0000 @@ -67,7 +67,7 @@ fi # Launch update-web-ari.sh in same directory as current script. -${scriptpath}/update-web-ari.sh ${srcdir} ${tempdir} ${webdir} gdb +${SHELL} ${scriptpath}/update-web-ari.sh ${srcdir} ${tempdir} ${webdir} gdb if [ -f "${webdir}/index.html" ] ; then echo "ARI output can be viewed in file \"${webdir}/index.html\"" ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <11663.278603419$1352113627@news.gmane.org>]
* Re: [RFA-v2] contrib/ari: Avoid permission issue for script [not found] ` <11663.278603419$1352113627@news.gmane.org> @ 2012-11-05 19:39 ` Tom Tromey 2012-11-06 8:26 ` Pierre Muller 0 siblings, 1 reply; 8+ messages in thread From: Tom Tromey @ 2012-11-05 19:39 UTC (permalink / raw) To: Pierre Muller; +Cc: gdb-patches >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes: Pierre> 2012-11-05 Pierre Muller <muller@sourceware.org> Pierre> * contrib/ari/create-web-ari-in-src.sh: Avoid problem if script Pierre> is not executable. Looks good to me. Tom ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFA-v2] contrib/ari: Avoid permission issue for script 2012-11-05 19:39 ` Tom Tromey @ 2012-11-06 8:26 ` Pierre Muller 0 siblings, 0 replies; 8+ messages in thread From: Pierre Muller @ 2012-11-06 8:26 UTC (permalink / raw) To: 'Tom Tromey'; +Cc: gdb-patches > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoyé : lundi 5 novembre 2012 20:39 > À : Pierre Muller > Cc : gdb-patches@sourceware.org > Objet : Re: [RFA-v2] contrib/ari: Avoid permission issue for script > > >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes: > > Pierre> 2012-11-05 Pierre Muller <muller@sourceware.org> > > Pierre> * contrib/ari/create-web-ari-in-src.sh: Avoid problem if > script > Pierre> is not executable. > > Looks good to me. Thanks for the approval, Tom. Patch committed: http://sourceware.org/ml/gdb-cvs/2012-11/msg00038.html Pierre Muller ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-11-06 8:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <11045.9555559375$1351807023@news.gmane.org>
2012-11-02 17:27 ` [RFA] contrib/ari: Avoid permission issue for script Tom Tromey
2012-11-02 17:31 ` Pedro Alves
2012-11-02 18:25 ` Pierre Muller
2012-11-02 18:33 ` Pedro Alves
2012-11-02 18:44 ` Andreas Schwab
2012-11-05 11:06 ` [RFA-v2] " Pierre Muller
[not found] ` <11663.278603419$1352113627@news.gmane.org>
2012-11-05 19:39 ` Tom Tromey
2012-11-06 8:26 ` Pierre Muller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox