From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Tom Tromey'" <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: [RFA-v2] contrib/ari: Avoid permission issue for script
Date: Mon, 05 Nov 2012 11:06:00 -0000 [thread overview]
Message-ID: <003001cdbb45$9ed5c640$dc8152c0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <87a9uzq5j1.fsf@fleche.redhat.com>
> Pierre> I can lift the problem for the main script,
> Pierre> by calling it using:
> Pierre> sh ../../src/gdb/contrib/ari/ create-web-ari-in-src.sh,
> Pierre> but this script calls update-web-ari.sh script
> Pierre> without using '. script'...
>
> I think you probably want $SHELL rather than '.' here.
> '.' runs it in the current shell, but the previous code launched a new
> shell.
You are right of course.
Here is a new version of the patch.
> Pierre> Should I add myself as contrib/ari maintainer?
>
> Sure.
Submitted as a seperate thread.
ChangeLog entry:
2012-11-05 Pierre Muller <muller@sourceware.org>
* contrib/ari/create-web-ari-in-src.sh: Avoid problem if script
is not executable.
Index: create-web-ari-in-src.sh
===================================================================
RCS file: /cvs/src/src/gdb/contrib/ari/create-web-ari-in-src.sh,v
retrieving revision 1.3
diff -u -r1.3 create-web-ari-in-src.sh
--- create-web-ari-in-src.sh 2 Nov 2012 18:19:36 -0000 1.3
+++ create-web-ari-in-src.sh 5 Nov 2012 11:03:29 -0000
@@ -67,7 +67,7 @@
fi
# Launch update-web-ari.sh in same directory as current script.
-${scriptpath}/update-web-ari.sh ${srcdir} ${tempdir} ${webdir} gdb
+${SHELL} ${scriptpath}/update-web-ari.sh ${srcdir} ${tempdir} ${webdir} gdb
if [ -f "${webdir}/index.html" ] ; then
echo "ARI output can be viewed in file \"${webdir}/index.html\""
next prev parent reply other threads:[~2012-11-05 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11045.9555559375$1351807023@news.gmane.org>
2012-11-02 17:27 ` [RFA] " Tom Tromey
2012-11-02 17:31 ` Pedro Alves
2012-11-02 18:25 ` Pierre Muller
2012-11-02 18:33 ` Pedro Alves
2012-11-02 18:44 ` Andreas Schwab
2012-11-05 11:06 ` Pierre Muller [this message]
[not found] ` <11663.278603419$1352113627@news.gmane.org>
2012-11-05 19:39 ` [RFA-v2] " Tom Tromey
2012-11-06 8:26 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003001cdbb45$9ed5c640$dc8152c0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox