From: Tom Tromey <tromey@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [1/2] Add new 'z' format for print command
Date: Wed, 10 Jul 2013 17:30:00 -0000 [thread overview]
Message-ID: <878v1egw5r.fsf@fleche.redhat.com> (raw)
In-Reply-To: <51DAF728.4040309@broadcom.com> (Andrew Burgess's message of "Mon, 8 Jul 2013 18:30:16 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
Andrew> Pedro pointed out that I could do better, so, this patch
Andrew> introduces a new 'z' format within the core value printing
Andrew> code that displays scalars using zero padded hexadecimal.
Andrew> I've mentioned this in the docs and added a test for the
Andrew> new format.
Andrew> In patch [2/2] I'll change the MI code to make use of this
Andrew> new 'z' formatter.
Andrew> OK to apply?
It looks good to me. However, it needs a doc review, and also, I think,
a NEWS entry.
Plus, I think we should wait a little bit in case anyone has an issue
with the choice of 'z'.
thanks,
Tom
next prev parent reply other threads:[~2013-07-10 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 17:30 Andrew Burgess
2013-07-10 17:30 ` Tom Tromey [this message]
2013-07-11 15:20 ` Andrew Burgess
2013-07-18 7:57 ` Andrew Burgess
2013-07-24 10:07 ` [PING (docs)] " Andrew Burgess
2013-07-24 14:35 ` Eli Zaretskii
2013-07-24 15:16 ` Andrew Burgess
2013-07-24 17:00 ` Eli Zaretskii
2013-07-24 17:08 ` Andrew Burgess
2013-07-24 17:43 ` Eli Zaretskii
2013-07-25 10:18 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v1egw5r.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox