From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 735 invoked by alias); 10 Jul 2013 17:30:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 725 invoked by uid 89); 10 Jul 2013 17:30:36 -0000 X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 10 Jul 2013 17:30:35 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6AHUY3x023405 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 10 Jul 2013 13:30:34 -0400 Received: from barimba (ovpn-113-131.phx2.redhat.com [10.3.113.131]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6AHURbe020144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 10 Jul 2013 13:30:33 -0400 From: Tom Tromey To: "Andrew Burgess" Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] [1/2] Add new 'z' format for print command References: <51DAF728.4040309@broadcom.com> Date: Wed, 10 Jul 2013 17:30:00 -0000 In-Reply-To: <51DAF728.4040309@broadcom.com> (Andrew Burgess's message of "Mon, 8 Jul 2013 18:30:16 +0100") Message-ID: <878v1egw5r.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00283.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Pedro pointed out that I could do better, so, this patch Andrew> introduces a new 'z' format within the core value printing Andrew> code that displays scalars using zero padded hexadecimal. Andrew> I've mentioned this in the docs and added a test for the Andrew> new format. Andrew> In patch [2/2] I'll change the MI code to make use of this Andrew> new 'z' formatter. Andrew> OK to apply? It looks good to me. However, it needs a doc review, and also, I think, a NEWS entry. Plus, I think we should wait a little bit in case anyone has an issue with the choice of 'z'. thanks, Tom