From: "Andrew Burgess" <aburgess@broadcom.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PING (docs)] Re: [PATCH] [1/2] Add new 'z' format for print command
Date: Wed, 24 Jul 2013 15:16:00 -0000 [thread overview]
Message-ID: <51EFEFB1.4070408@broadcom.com> (raw)
In-Reply-To: <83k3kgvxf2.fsf@gnu.org>
On 24/07/2013 3:34 PM, Eli Zaretskii wrote:
> More importantly, I have a difficulty understanding what does
> "hexadecimal zero padded to the size ..." mean. More accurately, if
> my interpretation of what you say (that 'z' produces "00"s for
> non-existing data, then why does this "padding" make sense, when we
> are targeting a human consumer?
I'm not sure I agree with the "non-existing data" part of your
statement, for example a 4-byte register containing the value 1 (one)
when printed with /x would print 0x1, with /z it would print 0x00000001,
surely the leading 0s do exist, we just normally don't print them.
I agree that for a human consumer /z might not be so useful, but moving
this code from being MI specific, to being a core format has cleaned up
an annoying bug, and does mean that the two interfaces offer the same
set of display formats.
You might argue that either:
(1) We should prevent this format being used in non-mi mode as it is
not useful. Given what a small feature this is, and for the
consistent interface reason, I'd prefer to keep it available. Or,
(2) We allow it, but only document it in the MI part of the document,
so CLI users are not 'tempted' to use it. I don't like this as it
presupposes what a user will / will not find useful, and make the
documentation seem incomplete.
I'd be interested to get your thoughts though.
Thanks,
Andrew
next prev parent reply other threads:[~2013-07-24 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 17:30 Andrew Burgess
2013-07-10 17:30 ` Tom Tromey
2013-07-11 15:20 ` Andrew Burgess
2013-07-18 7:57 ` Andrew Burgess
2013-07-24 10:07 ` [PING (docs)] " Andrew Burgess
2013-07-24 14:35 ` Eli Zaretskii
2013-07-24 15:16 ` Andrew Burgess [this message]
2013-07-24 17:00 ` Eli Zaretskii
2013-07-24 17:08 ` Andrew Burgess
2013-07-24 17:43 ` Eli Zaretskii
2013-07-25 10:18 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EFEFB1.4070408@broadcom.com \
--to=aburgess@broadcom.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox