Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: orgads@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix cache dir resolving on Windows
Date: Fri, 07 Jun 2019 18:10:00 -0000	[thread overview]
Message-ID: <878sud6zbn.fsf@tromey.com> (raw)
In-Reply-To: <20190607062719.10989-1-orgads@gmail.com> (orgads's message of	"Fri, 7 Jun 2019 09:27:19 +0300")

>> +#ifdef _WIN32
>> +  if (home == nullptr)
>> +      home = getenv ("APPDATA");

I think the assignment line is indented a bit too far -- should be 2
spaces over from the "if", per the GNU style.

thanks,
Tom


      parent reply	other threads:[~2019-06-07 18:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 19:37 orgads
2019-06-04 14:44 ` Eli Zaretskii
2019-06-04 15:06   ` Simon Marchi
2019-06-04 16:17     ` Eli Zaretskii
2019-06-07  6:21 ` orgads
2019-06-07  6:23   ` Orgad Shaneh
2019-06-07  6:27   ` Eli Zaretskii
2019-06-07  6:27 ` orgads
2019-06-07  7:36   ` Eli Zaretskii
2019-06-07  8:01     ` Eli Zaretskii
     [not found]       ` <CAGHpTB+Y+kO=ZiKtTft3yG4mMR+27DYfqJGQWBLvu=VKCgRyLw@mail.gmail.com>
2019-06-07 12:29         ` Eli Zaretskii
2019-06-07 18:10   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sud6zbn.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=orgads@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox