Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: orgads@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix cache dir resolving on Windows
Date: Fri, 07 Jun 2019 08:01:00 -0000	[thread overview]
Message-ID: <83ftolrfie.fsf@gnu.org> (raw)
In-Reply-To: <83h891rgmw.fsf@gnu.org> (message from Eli Zaretskii on Fri, 07	Jun 2019 10:36:39 +0300)

> Date: Fri, 07 Jun 2019 10:36:39 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> CC: gdb-patches@sourceware.org
> 
> >    const char *home = getenv ("HOME");
> > +#ifdef _WIN32
> > +  if (home == nullptr)
> > +      home = getenv ("APPDATA");
> > +#endif
> >    if (home != NULL)
> >      {
> >        /* Make sure the path is absolute and tilde-expanded.  */
> 
> Thanks, this LGTM.

Actually, I see that we mention HOME on Windows in the manual, in a
footnote that's part of the "Startup" node.  I think we should
document this addition there.  Would you like to add a change to the
manual as well?

Thanks.

P.S. I see that you don't have a copyright assignment on file, which
means we are limited in the amount of changes we can accept from you.
Would you like to start the legal paperwork of assigning to the FSF
the copyright for your changes?  If so, I will send you the form to
fill.


  reply	other threads:[~2019-06-07  8:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 19:37 orgads
2019-06-04 14:44 ` Eli Zaretskii
2019-06-04 15:06   ` Simon Marchi
2019-06-04 16:17     ` Eli Zaretskii
2019-06-07  6:21 ` orgads
2019-06-07  6:23   ` Orgad Shaneh
2019-06-07  6:27   ` Eli Zaretskii
2019-06-07  6:27 ` orgads
2019-06-07  7:36   ` Eli Zaretskii
2019-06-07  8:01     ` Eli Zaretskii [this message]
     [not found]       ` <CAGHpTB+Y+kO=ZiKtTft3yG4mMR+27DYfqJGQWBLvu=VKCgRyLw@mail.gmail.com>
2019-06-07 12:29         ` Eli Zaretskii
2019-06-07 18:10   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ftolrfie.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=orgads@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox