From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87496 invoked by alias); 7 Jun 2019 08:01:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87488 invoked by uid 89); 7 Jun 2019 08:01:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=p.s, P.S, PS, UD:P.S X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Jun 2019 08:01:09 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZ9oB-0006Uv-UQ; Fri, 07 Jun 2019 04:01:07 -0400 Received: from [176.228.60.248] (port=2957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZ9oB-0000cb-6z; Fri, 07 Jun 2019 04:01:07 -0400 Date: Fri, 07 Jun 2019 08:01:00 -0000 Message-Id: <83ftolrfie.fsf@gnu.org> From: Eli Zaretskii To: orgads@gmail.com CC: gdb-patches@sourceware.org In-reply-to: <83h891rgmw.fsf@gnu.org> (message from Eli Zaretskii on Fri, 07 Jun 2019 10:36:39 +0300) Subject: Re: [PATCH] Fix cache dir resolving on Windows References: <20190603193716.4861-1-orgads@gmail.com> <20190607062719.10989-1-orgads@gmail.com> <83h891rgmw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00157.txt.bz2 > Date: Fri, 07 Jun 2019 10:36:39 +0300 > From: Eli Zaretskii > CC: gdb-patches@sourceware.org > > > const char *home = getenv ("HOME"); > > +#ifdef _WIN32 > > + if (home == nullptr) > > + home = getenv ("APPDATA"); > > +#endif > > if (home != NULL) > > { > > /* Make sure the path is absolute and tilde-expanded. */ > > Thanks, this LGTM. Actually, I see that we mention HOME on Windows in the manual, in a footnote that's part of the "Startup" node. I think we should document this addition there. Would you like to add a change to the manual as well? Thanks. P.S. I see that you don't have a copyright assignment on file, which means we are limited in the amount of changes we can accept from you. Would you like to start the legal paperwork of assigning to the FSF the copyright for your changes? If so, I will send you the form to fill.