From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101081 invoked by alias); 7 Jun 2019 18:10:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100913 invoked by uid 89); 7 Jun 2019 18:10:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:253 X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.91) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Jun 2019 18:10:55 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id AB9489E17 for ; Fri, 7 Jun 2019 13:10:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZJKHhIRhi4FKpZJKHhbyg5; Fri, 07 Jun 2019 13:10:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kpAjwmcPKvZRyBDuHTAnh5SZsjLwLx6yfmHrSFTwQBE=; b=cyqVbkKsVI9+uJz/ObaT69uq5Z QG8Fu0bIDUlWK9OlOihunn248OAulpZ3uuQskn5s+E9mA0kpw8S7RsAYTY0SnoAixuzowzgHEOII0 s7TA/xP3hYS31gWtvw2nIfpWZ; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:48742 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hZJKH-002ROQ-Eg; Fri, 07 Jun 2019 13:10:53 -0500 From: Tom Tromey To: orgads@gmail.com Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix cache dir resolving on Windows References: <20190603193716.4861-1-orgads@gmail.com> <20190607062719.10989-1-orgads@gmail.com> Date: Fri, 07 Jun 2019 18:10:00 -0000 In-Reply-To: <20190607062719.10989-1-orgads@gmail.com> (orgads's message of "Fri, 7 Jun 2019 09:27:19 +0300") Message-ID: <878sud6zbn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00161.txt.bz2 >> +#ifdef _WIN32 >> + if (home == nullptr) >> + home = getenv ("APPDATA"); I think the assignment line is indented a bit too far -- should be 2 spaces over from the "if", per the GNU style. thanks, Tom