Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Replace most calls to help_list and cmd_show_list
Date: Fri, 17 Apr 2020 15:14:12 -0600	[thread overview]
Message-ID: <878sitke6z.fsf@tromey.com> (raw)
In-Reply-To: <4eba2611-ddaf-6f70-9b5d-15b12e455ee5@simark.ca> (Simon Marchi's message of "Fri, 17 Apr 2020 17:02:37 -0400")

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> In some cases, a bit of output was remove; however, I don't think this

Simon> removed

Fixed.

>> output in general was very useful.  It seemed redundant with what's
>> already printed by help_list.

Simon> Could you mention here an example of command for which the output changed?

I've updated the commit message with an example.

Simon> I did not read it all, but I glanced at some files.  It removes a lot of
Simon> duplicated code and boilerplate, and therefore chances of inconsistencies,
Simon> which is nice.

Thanks.  I'm going to push it in shortly.

Tom


      reply	other threads:[~2020-04-17 21:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 13:29 Tom Tromey
2020-04-17 21:02 ` Simon Marchi
2020-04-17 21:14   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sitke6z.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox