Re: [PATCH] Replace most calls to help_list and cmd_show_list

[Simon Marchi <simark@simark.ca>]

On 2020-04-17 9:29 a.m., Tom Tromey wrote:
> Currently there are many prefix commands that do nothing but call
> either help_list or cmd_show_list.  I happened to notice that one such
> call, for "set print type", used the wrong command list parameter,
> causing incorrect output.
> 
> Rather than fix this bug in isolation, I decided to eliminate this
> possibility by adding two new ways to add prefix commands, which
> simply route the call to help_list or cmd_show_list, as appropriate.
> This makes it impossible for a mismatch to occur.
> 
> In some cases, a bit of output was remove; however, I don't think this

removed

> output in general was very useful.  It seemed redundant with what's
> already printed by help_list.

Could you mention here an example of command for which the output changed?

> 
> This simplified the CLI style set/show commands quite a bit, and
> allowed the deletion of a macro.
> 
> This also cleans up some unusual code in windows-tdep.c.
> 
> Tested on x86-64 Fedora 30.  Note that I have no way to build the
> go32-nat.c change.

I did not read it all, but I glanced at some files.  It removes a lot of
duplicated code and boilerplate, and therefore chances of inconsistencies,
which is nice.

Simon