From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tromey@adacore.com>
Received: from rock.gnat.com (rock.gnat.com
 [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1])
 by sourceware.org (Postfix) with ESMTP id 75375385B835
 for <gdb-patches@sourceware.org>; Fri, 17 Apr 2020 21:14:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 75375385B835
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=tromey@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id 33E0D56085;
 Fri, 17 Apr 2020 17:14:13 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id bo7Bg3CrcDsi; Fri, 17 Apr 2020 17:14:13 -0400 (EDT)
Received: from murgatroyd (174-16-123-2.hlrn.qwest.net [174.16.123.2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by rock.gnat.com (Postfix) with ESMTPSA id C855756083;
 Fri, 17 Apr 2020 17:14:12 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Replace most calls to help_list and cmd_show_list
References: <20200417132940.3978-1-tromey@adacore.com>
 <4eba2611-ddaf-6f70-9b5d-15b12e455ee5@simark.ca>
X-Attribution: Tom
Date: Fri, 17 Apr 2020 15:14:12 -0600
In-Reply-To: <4eba2611-ddaf-6f70-9b5d-15b12e455ee5@simark.ca> (Simon Marchi's
 message of "Fri, 17 Apr 2020 17:02:37 -0400")
Message-ID: <878sitke6z.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Apr 2020 21:14:14 -0000

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> In some cases, a bit of output was remove; however, I don't think this

Simon> removed

Fixed.

>> output in general was very useful.  It seemed redundant with what's
>> already printed by help_list.

Simon> Could you mention here an example of command for which the output changed?

I've updated the commit message with an example.

Simon> I did not read it all, but I glanced at some files.  It removes a lot of
Simon> duplicated code and boilerplate, and therefore chances of inconsistencies,
Simon> which is nice.

Thanks.  I'm going to push it in shortly.

Tom