Re: [PATCH v3 2/2] gdb, dwarf: create symbols for template tags without names

[Tom Tromey <tom@tromey.com>]

>>>>> Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org> writes:

> +  die_info* child = die->parent->child;

The "*" is in the wrong spot.

> +  while (child != die && child != nullptr)

Here the loop condition checks for nullptr, but below the assert does
not:

> +  }
> +  gdb_assert (child == die);

It seems to me that one or the other must be incorrect.

> +  const std::string name_str = "<unnamed" + std::to_string (nth_unnamed) + ">";
> +  return obstack_strndup (&cu->per_objfile->objfile->per_bfd->storage_obstack,
> +			  name_str.c_str (), name_str.size ());

Better IMO to use objfile::intern.

thanks,
Tom