RE: [PATCH v3 2/2] gdb, dwarf: create symbols for template tags without names

["Kempke, Nils-Christian via Gdb-patches" <gdb-patches@sourceware.org>]

Hi Tom,

Thanks for the review!

> > +  die_info* child = die->parent->child;
> 
> The "*" is in the wrong spot.

Fixed in v4.
 
> > +  while (child != die && child != nullptr)
> 
> Here the loop condition checks for nullptr, but below the assert does
> not:
> 
> > +  }
> > +  gdb_assert (child == die);
> 
> It seems to me that one or the other must be incorrect.

Mh, here I am not sure.  Theoretically, I'd assume that the die we are
looking at will definitely be a child of its parent.  The setup would be severely
broken if not.  However, if it is broken, then the children we are iterating over
would, at some point, not have siblings anymore and child->sibling would be
NULL.  I added the child != nullptr check to the loop condition to catch this case
and not run into a Segfault.

The  gdb_assert (child == die) also implies that child != nullptr as we assume that
die != nullptr (even though we don't check this explicitly, but dwarf2_name, the
only caller of unnamed_template_tag_name also just assumes die != nullptr).
I just added the assert to make sure we did not exit the loop because of broken
child-parent relations.  I don't think either of them is really wrong.

Then, looking at this again I think the better solution is to have 
  while (child != die)
as the loop condition and
  gdb_assert (child != nullptr)
inside the while and remove the gdb_assert (child == die).  I'll change it to that
for v4 now.

> 
> > +  const std::string name_str = "<unnamed" + std::to_string
> (nth_unnamed) + ">";
> > +  return obstack_strndup (&cu->per_objfile->objfile->per_bfd-
> >storage_obstack,
> > +			  name_str.c_str (), name_str.size ());
> 
> Better IMO to use objfile::intern.

Yes, changed in v4.
 
Thanks,
Nils
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928