From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GHGOLTwlBWMdLCwAWB0awg (envelope-from ) for ; Tue, 23 Aug 2022 15:06:36 -0400 Received: by simark.ca (Postfix, from userid 112) id AD8331E4A7; Tue, 23 Aug 2022 15:06:36 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=S+36S0DD; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 29A731E222 for ; Tue, 23 Aug 2022 15:06:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C4D53858C83 for ; Tue, 23 Aug 2022 19:06:30 +0000 (GMT) Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 62A653858D37 for ; Tue, 23 Aug 2022 19:06:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 62A653858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 658831003FA02 for ; Tue, 23 Aug 2022 19:06:08 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QZDzoNLS0CokGQZDzoNRwt; Tue, 23 Aug 2022 19:06:07 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=c8Nu/Txl c=1 sm=1 tr=0 ts=6305251f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=biHskzXt2R4A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=2LVW50CItKf3nQNrVEMA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2WMJ/1LTKegIa9me90RtKStZ61yr8ooQrdSIlKXIs1I=; b=S+36S0DDSx/OfuIRV1DINiVbQT EP7BC7lqstVapO6CE1a3asSHyH5xSEYreWj0IlyrAm73p2tDNZCoDkOAb/VAffQyriGfo4NjSa0E8 TP8iYFFBy4NMv5qAGIPTAMSQf; Received: from 71-211-185-105.hlrn.qwest.net ([71.211.185.105]:56344 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oQZDz-003nWt-5D; Tue, 23 Aug 2022 13:06:07 -0600 From: Tom Tromey To: Nils-Christian Kempke via Gdb-patches Subject: Re: [PATCH v3 2/2] gdb, dwarf: create symbols for template tags without names References: <20220823153656.1235982-1-nils-christian.kempke@intel.com> <20220823153656.1235982-3-nils-christian.kempke@intel.com> X-Attribution: Tom Date: Tue, 23 Aug 2022 13:06:06 -0600 In-Reply-To: <20220823153656.1235982-3-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Tue, 23 Aug 2022 17:36:56 +0200") Message-ID: <878rnedbkx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.105 X-Source-L: No X-Exim-ID: 1oQZDz-003nWt-5D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-105.hlrn.qwest.net (murgatroyd) [71.211.185.105]:56344 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> Nils-Christian Kempke via Gdb-patches writes: > + die_info* child = die->parent->child; The "*" is in the wrong spot. > + while (child != die && child != nullptr) Here the loop condition checks for nullptr, but below the assert does not: > + } > + gdb_assert (child == die); It seems to me that one or the other must be incorrect. > + const std::string name_str = ""; > + return obstack_strndup (&cu->per_objfile->objfile->per_bfd->storage_obstack, > + name_str.c_str (), name_str.size ()); Better IMO to use objfile::intern. thanks, Tom