Re: [PATCH v4 0/4] [gdb] Fix missing print frame when stepping out of function

[Andrew Burgess <aburgess@redhat.com>]

Tom de Vries <tdevries@suse.de> writes:

> This patch series consisting of four patches.
>
> The first patch extends test-case gdb.opt/inline-cmds.exp.
>
> The second patch does some refactoring, to make the following fix minimal.
>
> The third patch contains a fix for PR33981.
>
> The fourth patch does a cleanup in function print_stop_location.
>
> A v1 was submitted here [1].
>
> Changes in v2 [2]:
> - added two refactoring patches
> - changed approach after review comment by Andrew, changing
>   in_step_start_function usage to notice stepping in and out of inlined
>   functions
>
> Changes in v3 [3]:
> - dropped first refactoring patch
> - merged second refactoring patch into patch containing fix
> - changed approach from using find_symbol_for_pc_sect_maybe_inline to using
>   get_frame_function
> - extended test-case gdb.opt/inline-cmds.exp
> - added patch with cleanup in function print_stop_location
>
> Changes in v4:
> - factored out patch extending test-case gdb.opt/inline-cmds.exp
> - re-instated refactoring patch
> - updated cleanup patch to use selected frame instead of current frame

Thanks for all your work on this series.

I don't fully see the need for the split between patches #2 and #3, but
I don't object if that's your preference.  I think this is looking good.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew



>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33981
>
> [1] v1 https://sourceware.org/pipermail/gdb-patches/2026-March/225916.html
> [2] v2 (RFC) https://sourceware.org/pipermail/gdb-patches/2026-March/226269.html
> [3] v3 https://sourceware.org/pipermail/gdb-patches/2026-April/226330.html
>
> Andrew Burgess (2):
>   [gdb/testsuite] Extend gdb.opt/inline-cmds.exp
>   gdb: use get_current_frame consistently in print_stop_location
>
> Tom de Vries (2):
>   [gdb] Add thread_control_state::step_start_function methods
>   gdb: fix missing print frame when stepping out of function
>
>  gdb/gdbthread.h                               | 36 ++++++++++++++-
>  gdb/infcmd.c                                  |  3 +-
>  gdb/infrun.c                                  | 25 ++++++-----
>  .../gdb.dwarf2/dw2-extend-inline-block.exp    | 45 +++++++++++++++++--
>  gdb/testsuite/gdb.opt/inline-cmds.exp         | 33 +++++++++-----
>  5 files changed, 113 insertions(+), 29 deletions(-)
>
>
> base-commit: d7e49fd331d5a9a66d467c7d5cb4b5fc156a1ee0
> -- 
> 2.51.0