From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id d+2AMjts3mndLBcAWB0awg (envelope-from ) for ; Tue, 14 Apr 2026 12:32:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=agXvfgS2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF2171E04F; Tue, 14 Apr 2026 12:32:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2B07F1E04F for ; Tue, 14 Apr 2026 12:32:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 523E14BA23C2 for ; Tue, 14 Apr 2026 16:32:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 523E14BA23C2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=agXvfgS2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 75BCB4BA2E06 for ; Tue, 14 Apr 2026 16:32:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75BCB4BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 75BCB4BA2E06 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776184353; cv=none; b=V4kDeJJydvdnsM61Gq2WG21C0eX5miSbwDMae9u33wMuYrkI3KJYyvW5Qt473aX4XMb/U35K3n212cICs7RkLBCEk70NgIWxLMmNjk48jbXHmWwtfJxlNpwrUvuppoMrzjgmd2xYQRvwunySCdAXel2Fw63kbZ7AnGmEu0J6hWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776184353; c=relaxed/simple; bh=TKhsao0MzanKgnhy07ePw4aE3tyggqnOZATRzMc365s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VT+LTEAcSfj2MEmh2YiBFDX37EMZ9MKQj2K2Lm0drx2O7yTyXyMWNvK/qAlMfX2hirEde499Tu4CiHpR84XZAfmDRDvlwn2WvYDSdiYNVnXs1DvhE0D8/IhqQl7g21PxTHewsIkenpjUj8H1EDhzsmGEMjcXTfelrKcsQW/P8YQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75BCB4BA2E06 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776184353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g9GM6nk0Pb+X8BZCGtii7AsRSJ6XLAjIdRjx6b68xLw=; b=agXvfgS2MXn7pxFENXA/5+FLlfzahSKjzANNrH8pEt1TeuKzdNLENNi6ogcGS3opkGqDuV HCNwEdDBrOA2LW57EpKNWMAx1l6Ew/dafB9Bw0ZhuE/uy5/ltuBbFW01Uotu5tbOT+565+ kHasawq0CeNUHE0+w8reQ2/dpERlVaE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-IbjyBojuNXGlSeJGriY1UQ-1; Tue, 14 Apr 2026 12:32:32 -0400 X-MC-Unique: IbjyBojuNXGlSeJGriY1UQ-1 X-Mimecast-MFC-AGG-ID: IbjyBojuNXGlSeJGriY1UQ_1776184351 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4839fc4cef6so47563175e9.0 for ; Tue, 14 Apr 2026 09:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776184351; x=1776789151; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g9GM6nk0Pb+X8BZCGtii7AsRSJ6XLAjIdRjx6b68xLw=; b=R0JtgaxM0nMfktNmZLbWYmq2HJP/fqfAW2c3bnAxIrCvBlaUrWEYHljJ2MLRnGakCU HRo/aCZbb0QNbC2HqO1TdVOWYgeaGprfHwTX1tenJguicOwcPMjd43dDv8uuQMxX4Tfc 1zcTGIDs7YtEq1ks8ZV1XZ5fqGfitL8vpoZZK/mfd4U2TBzkvhqOu0pjLZUF9LTZTXre EHrr9r+mMX3OUF8kyU6KjzLO79NM/S+BkTLTmgqBL7Bw/6fkRqQcCkRoIHAh4Vtw6fmj ItJaFlUl7vFqe/dlSgl0DWZgyhLfgA+6vAkPqLfpnOyzabfqo1se0rFGKbnT7c+Rw4UW mnYA== X-Forwarded-Encrypted: i=1; AFNElJ/tJlzYfHjsXHV+oMvg1GzdR6XmJxuoqYJueKWlmGGGKcCaVb6+PQuOVNMphSreX5GrYIZ770+OB+5dJw==@sourceware.org X-Gm-Message-State: AOJu0YzIPbckuDhCu7T/hM+auw0Gz9qSEZNGKx/n9mvJMaxY6SJof8/H WRi6SrANG/c95G64LOgoMkbohQIJP24cbmspWrUc6dQKwg9Yx4/AJRXtP/OgOokPPOtQaGUvGGL jT4LxNRz+DvUJb6jwS19D81KMTHB0JH+JivnmztRsQJfwIaKhXuZymWX1idWbc3M= X-Gm-Gg: AeBDieudqWFjYXDsrMtfp8TOdCinLb4jhE2zpcu1r0zL0sVK11ngF/DEI6LehlX7q0F CyAzIv/OhCUwyXeLHTqKUoukyHc6BX/+6GiDtQLPmNab2AHV2coljl81FbkQ4yovDUyPMcosW/R 0hUtEauWtY9EPUZOSG3A3hbUFol//UAM/1rZOULIhbjvzmuumv5a1BkubHBUnMXZlQFVogEoloH jUHkL3yLc0eW2Dg7kAqqGndGKCSOtTqNslYLQq8CwhwbTNLwUyV4PybiIH140ct6mMwyfvZEwGN 5eMQKNCc9l6eouaBvsB432skdPp6OLmTzYrRKeFjRcNnrt9i7t2FBujEr+Me/+cMn+vpJozna6s rbDS9I73HM+IhqC7bW6PuH7dqmP0= X-Received: by 2002:a05:600d:a:b0:485:3428:774c with SMTP id 5b1f17b1804b1-488d682bb48mr182521545e9.4.1776184350802; Tue, 14 Apr 2026 09:32:30 -0700 (PDT) X-Received: by 2002:a05:600d:a:b0:485:3428:774c with SMTP id 5b1f17b1804b1-488d682bb48mr182521135e9.4.1776184350291; Tue, 14 Apr 2026 09:32:30 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ede249fasm61092615e9.7.2026.04.14.09.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 09:32:29 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH v4 0/4] [gdb] Fix missing print frame when stepping out of function In-Reply-To: <20260410101252.1805303-1-tdevries@suse.de> References: <20260410101252.1805303-1-tdevries@suse.de> Date: Tue, 14 Apr 2026 17:32:28 +0100 Message-ID: <878qapfqoz.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pNPAOgpkAXdd8SuktG09iRxewltALSYa-Vs0BEIACe4_1776184351 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > This patch series consisting of four patches. > > The first patch extends test-case gdb.opt/inline-cmds.exp. > > The second patch does some refactoring, to make the following fix minimal. > > The third patch contains a fix for PR33981. > > The fourth patch does a cleanup in function print_stop_location. > > A v1 was submitted here [1]. > > Changes in v2 [2]: > - added two refactoring patches > - changed approach after review comment by Andrew, changing > in_step_start_function usage to notice stepping in and out of inlined > functions > > Changes in v3 [3]: > - dropped first refactoring patch > - merged second refactoring patch into patch containing fix > - changed approach from using find_symbol_for_pc_sect_maybe_inline to using > get_frame_function > - extended test-case gdb.opt/inline-cmds.exp > - added patch with cleanup in function print_stop_location > > Changes in v4: > - factored out patch extending test-case gdb.opt/inline-cmds.exp > - re-instated refactoring patch > - updated cleanup patch to use selected frame instead of current frame Thanks for all your work on this series. I don't fully see the need for the split between patches #2 and #3, but I don't object if that's your preference. I think this is looking good. Approved-By: Andrew Burgess Thanks, Andrew > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33981 > > [1] v1 https://sourceware.org/pipermail/gdb-patches/2026-March/225916.html > [2] v2 (RFC) https://sourceware.org/pipermail/gdb-patches/2026-March/226269.html > [3] v3 https://sourceware.org/pipermail/gdb-patches/2026-April/226330.html > > Andrew Burgess (2): > [gdb/testsuite] Extend gdb.opt/inline-cmds.exp > gdb: use get_current_frame consistently in print_stop_location > > Tom de Vries (2): > [gdb] Add thread_control_state::step_start_function methods > gdb: fix missing print frame when stepping out of function > > gdb/gdbthread.h | 36 ++++++++++++++- > gdb/infcmd.c | 3 +- > gdb/infrun.c | 25 ++++++----- > .../gdb.dwarf2/dw2-extend-inline-block.exp | 45 +++++++++++++++++-- > gdb/testsuite/gdb.opt/inline-cmds.exp | 33 +++++++++----- > 5 files changed, 113 insertions(+), 29 deletions(-) > > > base-commit: d7e49fd331d5a9a66d467c7d5cb4b5fc156a1ee0 > -- > 2.51.0