Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH v4 0/4] [gdb] Fix missing print frame when stepping out of function
Date: Fri, 10 Apr 2026 12:12:48 +0200	[thread overview]
Message-ID: <20260410101252.1805303-1-tdevries@suse.de> (raw)

This patch series consisting of four patches.

The first patch extends test-case gdb.opt/inline-cmds.exp.

The second patch does some refactoring, to make the following fix minimal.

The third patch contains a fix for PR33981.

The fourth patch does a cleanup in function print_stop_location.

A v1 was submitted here [1].

Changes in v2 [2]:
- added two refactoring patches
- changed approach after review comment by Andrew, changing
  in_step_start_function usage to notice stepping in and out of inlined
  functions

Changes in v3 [3]:
- dropped first refactoring patch
- merged second refactoring patch into patch containing fix
- changed approach from using find_symbol_for_pc_sect_maybe_inline to using
  get_frame_function
- extended test-case gdb.opt/inline-cmds.exp
- added patch with cleanup in function print_stop_location

Changes in v4:
- factored out patch extending test-case gdb.opt/inline-cmds.exp
- re-instated refactoring patch
- updated cleanup patch to use selected frame instead of current frame

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33981

[1] v1 https://sourceware.org/pipermail/gdb-patches/2026-March/225916.html
[2] v2 (RFC) https://sourceware.org/pipermail/gdb-patches/2026-March/226269.html
[3] v3 https://sourceware.org/pipermail/gdb-patches/2026-April/226330.html

Andrew Burgess (2):
  [gdb/testsuite] Extend gdb.opt/inline-cmds.exp
  gdb: use get_current_frame consistently in print_stop_location

Tom de Vries (2):
  [gdb] Add thread_control_state::step_start_function methods
  gdb: fix missing print frame when stepping out of function

 gdb/gdbthread.h                               | 36 ++++++++++++++-
 gdb/infcmd.c                                  |  3 +-
 gdb/infrun.c                                  | 25 ++++++-----
 .../gdb.dwarf2/dw2-extend-inline-block.exp    | 45 +++++++++++++++++--
 gdb/testsuite/gdb.opt/inline-cmds.exp         | 33 +++++++++-----
 5 files changed, 113 insertions(+), 29 deletions(-)


base-commit: d7e49fd331d5a9a66d467c7d5cb4b5fc156a1ee0
-- 
2.51.0


             reply	other threads:[~2026-04-10 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 10:12 Tom de Vries [this message]
2026-04-10 10:12 ` [PATCH v4 1/4] [gdb/testsuite] Extend gdb.opt/inline-cmds.exp Tom de Vries
2026-04-10 10:12 ` [PATCH v4 2/4] [gdb] Add thread_control_state::step_start_function methods Tom de Vries
2026-04-10 10:12 ` [PATCH v4 3/4] gdb: fix missing print frame when stepping out of function Tom de Vries
2026-04-10 10:12 ` [PATCH v4 4/4] gdb: use get_current_frame consistently in print_stop_location Tom de Vries
2026-04-14 16:32 ` [PATCH v4 0/4] [gdb] Fix missing print frame when stepping out of function Andrew Burgess
2026-04-14 20:41   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410101252.1805303-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox