Re: [PATCH 1/2] gdb: fix assertion when interrupting an empty remote target

[Tom Tromey <tom@tromey.com>]

>>>>> Stephan Rohr <stephan.rohr@intel.com> writes:

> From: "Rohr, Stephan" <stephan.rohr@intel.com>
> GDB asserts when sending an interrupt to an empty remote target, e.g.
> use stdio to connect to a remote target in non-stop mode:

>   'gdb -ex "set non-stop on" -ex "target extended-remote | gdbserver
>    --multi --once -'

> Interrupting the target triggers an assertion in 'find_inferior_pid'.
> Fix by checking for a valid thread in 'interrupt_target_1' for 'non-stop'
> mode.

Thanks.  The patch itself looks ok but I had a few nits with the test.

> diff --git a/gdb/testsuite/gdb.server/interrupt-empty-remote-target.exp b/gdb/testsuite/gdb.server/interrupt-empty-remote-target.exp
> new file mode 100644
> index 00000000000..34437a17d90
> --- /dev/null
> +++ b/gdb/testsuite/gdb.server/interrupt-empty-remote-target.exp
> @@ -0,0 +1,40 @@
> +# Copyright 2024 Free Software Foundation, Inc.

2026

> +standard_testfile server.c
> +
> +if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
> +    return -1
> +}

Is an executable even needed?

Also, plain 'return' here.

thanks,
Tom