From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MWnXG/SwmWoL+iUAWB0awg (envelope-from ) for ; Thu, 03 Sep 2026 13:40:04 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E4gnKaus; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6AC851E166; Thu, 03 Sep 2026 13:40:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 99B9D1E033 for ; Thu, 03 Sep 2026 13:40:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC9854B9DB55 for ; Thu, 3 Sep 2026 17:40:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC9854B9DB55 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E4gnKaus Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 9A6EF4BB1C0B for ; Thu, 3 Sep 2026 17:39:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A6EF4BB1C0B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A6EF4BB1C0B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788457176; cv=none; b=RQPawSfBX6Q7XhXwhyv1I6WfUA//4GFJBVl9JmsIpPyOq8EnNtaDTa4VFx1GfnxZSvq3r9J0nAUVoeu5TSBs2RhiXfZFzuKb/1WuDQ4jc1DqNx9FwFRXVJzhujWAhrRF9eDJEevMmAx+kKnbW0LuX7PVc3jCY4RgIMUTjBDydLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788457176; c=relaxed/simple; bh=+/yubN+513udec3dwEb3bE2y1xz9mYsjlXu7WkxaQgw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Yr6NhHZx9/ObFEVX9ux2JMUwOz8n1ecrB5Q+8mVQoxkX0sByJq+yTlg6Y7AI2+uHwETUkJ7b12rnJY+t9yJ//gaGpldHlZkcSgxyfH5VZ+pCHyeGLs0//nryFRYV+FPYi88c2jlaxx5W4Aezcb/FRYosjTWUP2GgzJ1ODsE/nuo= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=E4gnKaus reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A6EF4BB1C0B Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id 25mYx1z6paC0U2BPSxeWdf; Thu, 03 Sep 2026 17:39:35 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 2BPSxIBhLbQ0n2BPSxZgt4; Thu, 03 Sep 2026 17:39:34 +0000 X-Authority-Analysis: v=2.4 cv=S4XZwJsP c=1 sm=1 tr=0 ts=6a99b0d6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=OsUbLXn-G4IdcwPqIPUA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TUiL9C4ekXa0Lrxj2coMAWw+ppTJnes4lYjexfMdSms=; b=E4gnKausx07Bqe3fCaYKo5KL4L U4b5SM0DWy7Y/bagl+hBRhe/hceE30cPE442UqGOdtsU4yNKraz/pevRQC6eI9EXqASBkBwKokaE0 pJ8EzLtNhuUvrH8al2I6zSpgD; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:37070 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1x2BPR-000000013FH-2sWC; Thu, 03 Sep 2026 11:39:33 -0600 From: Tom Tromey To: Stephan Rohr Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: fix assertion when interrupting an empty remote target In-Reply-To: <20260805085919.218925-2-stephan.rohr@intel.com> (Stephan Rohr's message of "Wed, 5 Aug 2026 08:59:17 +0000") References: <20260805085919.218925-1-stephan.rohr@intel.com> <20260805085919.218925-2-stephan.rohr@intel.com> X-Attribution: Tom Date: Thu, 03 Sep 2026 11:39:32 -0600 Message-ID: <878q5i2q0b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x2BPR-000000013FH-2sWC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:37070 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNH8WJVPU3UgUp3CJgPoiOrMAxO5WKO6kkeGl+ODXj/jnWNGE0O80zqoo6b1SsjPVWEXvrGjaVWidbsXVW6EusQ6r1iPNizmxDZpRx4c+KC2lqLXSPNz zfS7ldP7yM0Ld59byUcFCrn/+Hc4UVGy3UFEn/pav09PSG1T9MLxWOIttby0hLIp0PqU4nsEf4U87XMeLn4cGLqKkbiNrY8Dp5s= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Stephan Rohr writes: > From: "Rohr, Stephan" > GDB asserts when sending an interrupt to an empty remote target, e.g. > use stdio to connect to a remote target in non-stop mode: > 'gdb -ex "set non-stop on" -ex "target extended-remote | gdbserver > --multi --once -' > Interrupting the target triggers an assertion in 'find_inferior_pid'. > Fix by checking for a valid thread in 'interrupt_target_1' for 'non-stop' > mode. Thanks. The patch itself looks ok but I had a few nits with the test. > diff --git a/gdb/testsuite/gdb.server/interrupt-empty-remote-target.exp b/gdb/testsuite/gdb.server/interrupt-empty-remote-target.exp > new file mode 100644 > index 00000000000..34437a17d90 > --- /dev/null > +++ b/gdb/testsuite/gdb.server/interrupt-empty-remote-target.exp > @@ -0,0 +1,40 @@ > +# Copyright 2024 Free Software Foundation, Inc. 2026 > +standard_testfile server.c > + > +if {[build_executable "failed to prepare" $testfile $srcfile debug]} { > + return -1 > +} Is an executable even needed? Also, plain 'return' here. thanks, Tom