Re: [PATCH 2/2] gdb, remote: Skip sending of 'vCont' package if remote target is empty

[Tom Tromey <tom@tromey.com>]

>>>>> Stephan Rohr <stephan.rohr@intel.com> writes:

> From: "Rohr, Stephan" <stephan.rohr@intel.com>
> If the remote target has no threads that need to be stopped, we can
> skip sending the 'vCont' package in 'remote_stop_ns'.

s/package/packet/

> +  /* Skip 'vCont' package if there are no threads to be stopped.  */

Here too.

> +# Test that we do not see a 'vCont' package if we interrupt an empty
> +# remote target.
> +gdb_test_multiple "interrupt -a" "no vCont is sent" {
> +    -re -wrap "vCont.*" {
> +	fail $gdb_test_name
> +    }
> +    -re -wrap "" {
> +	pass $gdb_test_name
> +    }

I'm a little concerned that this could hit the "overflow" issue if
there's a lot of output.  However often I feel we just ignore this
problem unless it crops up in practice.

> +  bool empty ()
> +  { return begin () == end (); }

Probably should be a const method.

Tom