From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KiGzKOqxmWri/CUAWB0awg (envelope-from ) for ; Thu, 03 Sep 2026 13:44:10 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qT9n5ehn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 86E771E033; Thu, 03 Sep 2026 13:44:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F04641E033 for ; Thu, 03 Sep 2026 13:44:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 63F864B99F7E for ; Thu, 3 Sep 2026 17:44:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63F864B99F7E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qT9n5ehn Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 11FF14B9DB57 for ; Thu, 3 Sep 2026 17:43:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11FF14B9DB57 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11FF14B9DB57 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788457425; cv=none; b=ALAXspOn88eGRfr480bGZKtQv+TKZjD6sNymWAs6p10pVLvVGR09LccPMUcFOe2m0eGPQzB/CNJBJPK/dPaMfjofIV/9ujJ0zsEMtRkGeGS+lAOh5mVQA+ckIH8bv8qU3wFpCp/fgxD8mtMLffEyVYRsi7Mtg7ruNyoP7DEYoVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788457425; c=relaxed/simple; bh=YbrpSwY3aia5JCF79Iv3+C6GqfLRYj2vGzSR+akb8OU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IK2w1HAmUw4GubSknpMGR0aIIVvm5uKTi/8g5i6IB2MhjQQeKh2cmpexXfRSpwqB4VUFxUaGaGr0P5tsTV8k2DDXGsTc8EZoGWyzsLUl+zIvnIUFsgCPA3W56iqFVSEXEOObcH/oXQlhWYKbniVQ4kVau54MpIxmHXZe15JNH2s= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qT9n5ehn reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 11FF14B9DB57 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id 24ElxDDqlusRS2BTUx0QWo; Thu, 03 Sep 2026 17:43:44 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 2BTTx0of0adLA2BTTxMp3C; Thu, 03 Sep 2026 17:43:43 +0000 X-Authority-Analysis: v=2.4 cv=Aqzu3P9P c=1 sm=1 tr=0 ts=6a99b1cf a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=rEh5toHcCFwL_TQVpUYA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZSStGNboZymACDOnVA48GF3NfWToA05UQKCnwJRd1JM=; b=qT9n5ehnbj6qatXXH+K8Jss2KE 8oie3KcvBTxOD0TgXPTA+ytFIOYJ/LPo4Bv8b9O89DvgME0mfIJkO3xzI86FDpn/EawxcFN7TE5S7 e2NK9gTaD4OzeMIe3XEs/o9m5; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:33682 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1x2BTS-000000014iP-2qhn; Thu, 03 Sep 2026 11:43:42 -0600 From: Tom Tromey To: Stephan Rohr Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb, remote: Skip sending of 'vCont' package if remote target is empty In-Reply-To: <20260805085919.218925-3-stephan.rohr@intel.com> (Stephan Rohr's message of "Wed, 5 Aug 2026 08:59:18 +0000") References: <20260805085919.218925-1-stephan.rohr@intel.com> <20260805085919.218925-3-stephan.rohr@intel.com> X-Attribution: Tom Date: Thu, 03 Sep 2026 11:43:41 -0600 Message-ID: <874ig62pte.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x2BTS-000000014iP-2qhn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:33682 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOX8NOAqK5w1lKImDCqBlvljk3kuR7YyReldEf9g00F+vhRENCdWu1tX3dwDSQJr6mVeqLO2KWHSRj7Sr1K/+BgHq0J7OJUHF905ePEvOgZHKmgNzjCf VAcZG0cs9d7TJIT7QyAL3j0xYwKfkhhkrobiimRnoEjLr38GJ/HsFoI3ML7KeDHdAhOhnYTrngq953x7561AlMsSVqTb1bQF42Q= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Stephan Rohr writes: > From: "Rohr, Stephan" > If the remote target has no threads that need to be stopped, we can > skip sending the 'vCont' package in 'remote_stop_ns'. s/package/packet/ > + /* Skip 'vCont' package if there are no threads to be stopped. */ Here too. > +# Test that we do not see a 'vCont' package if we interrupt an empty > +# remote target. > +gdb_test_multiple "interrupt -a" "no vCont is sent" { > + -re -wrap "vCont.*" { > + fail $gdb_test_name > + } > + -re -wrap "" { > + pass $gdb_test_name > + } I'm a little concerned that this could hit the "overflow" issue if there's a lot of output. However often I feel we just ignore this problem unless it crops up in practice. > + bool empty () > + { return begin () == end (); } Probably should be a const method. Tom