From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] Set default target-wide-charset setting to "UTF-16" for x86_64-windows.
Date: Fri, 19 Oct 2012 20:48:00 -0000 [thread overview]
Message-ID: <877gqmur1v.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1350677219-10668-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Fri, 19 Oct 2012 13:06:59 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> * amd64-windows-tdep.c (amd64_windows_auto_wide_charset): New
Joel> function.
Joel> (amd64_windows_init_abi): Set auto_wide_charset gdbarch method
Joel> to amd64_windows_auto_wide_charset.
I think these are both fine, this is what the hook is for.
It makes me wonder though if we could defer guessing the default until a
spot where we know the size of the target wchar_t.
Tom
next prev parent reply other threads:[~2012-10-19 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 20:07 Joel Brobecker
2012-10-19 20:48 ` Tom Tromey [this message]
2012-10-23 15:38 ` checked in: " Joel Brobecker
2012-10-19 22:19 ` Eli Zaretskii
2012-10-19 23:27 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gqmur1v.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox