From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [RFA/commit] Set default target-wide-charset setting to "UTF-16" for x86_64-windows.
Date: Fri, 19 Oct 2012 20:07:00 -0000 [thread overview]
Message-ID: <1350677219-10668-1-git-send-email-brobecker@adacore.com> (raw)
GDB on x86_64-windows is having trouble printing wide characters.
For instance, from gdb.base/wchar.exp:
wchar_t narrow = 97; /* This is 'a' */
Without this patch, GDB prints narrow as:
$1 = 97 L'\141'
This is because the default target wide charset is UTF-32, whereas
wchar_t is only 16bits long.
gdb/ChangeLog:
* amd64-windows-tdep.c (amd64_windows_auto_wide_charset): New
function.
(amd64_windows_init_abi): Set auto_wide_charset gdbarch method
to amd64_windows_auto_wide_charset.
Tested on x86_64-windows, using AdaCore's testsuite. It seems to be
in line with what's done on x86-windows.
I'll commit in a few days unless there are objections.
---
gdb/amd64-windows-tdep.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/gdb/amd64-windows-tdep.c b/gdb/amd64-windows-tdep.c
index 528fbb6..142e141 100644
--- a/gdb/amd64-windows-tdep.c
+++ b/gdb/amd64-windows-tdep.c
@@ -190,6 +190,14 @@ amd64_windows_skip_trampoline_code (struct frame_info *frame, CORE_ADDR pc)
return destination;
}
+/* Implement the "auto_wide_charset" gdbarch method. */
+
+static const char *
+amd64_windows_auto_wide_charset (void)
+{
+ return "UTF-16";
+}
+
static void
amd64_windows_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
@@ -215,6 +223,8 @@ amd64_windows_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
set_gdbarch_iterate_over_objfiles_in_search_order
(gdbarch, windows_iterate_over_objfiles_in_search_order);
+ set_gdbarch_auto_wide_charset (gdbarch, amd64_windows_auto_wide_charset);
+
set_solib_ops (gdbarch, &solib_target_so_ops);
}
--
1.7.9.5
next reply other threads:[~2012-10-19 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 20:07 Joel Brobecker [this message]
2012-10-19 20:48 ` Tom Tromey
2012-10-23 15:38 ` checked in: " Joel Brobecker
2012-10-19 22:19 ` Eli Zaretskii
2012-10-19 23:27 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350677219-10668-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox