From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5523 invoked by alias); 19 Oct 2012 20:48:30 -0000 Received: (qmail 5355 invoked by uid 22791); 19 Oct 2012 20:48:26 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Oct 2012 20:48:16 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9JKmEb9013006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 19 Oct 2012 16:48:14 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9JKmCcZ022815 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Oct 2012 16:48:13 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Set default target-wide-charset setting to "UTF-16" for x86_64-windows. References: <1350677219-10668-1-git-send-email-brobecker@adacore.com> Date: Fri, 19 Oct 2012 20:48:00 -0000 In-Reply-To: <1350677219-10668-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Fri, 19 Oct 2012 13:06:59 -0700") Message-ID: <877gqmur1v.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00363.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> * amd64-windows-tdep.c (amd64_windows_auto_wide_charset): New Joel> function. Joel> (amd64_windows_init_abi): Set auto_wide_charset gdbarch method Joel> to amd64_windows_auto_wide_charset. I think these are both fine, this is what the hook is for. It makes me wonder though if we could defer guessing the default until a spot where we know the size of the target wchar_t. Tom