From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix kfail in gdb.base/callfuncs.exp
Date: Tue, 23 Oct 2012 18:41:00 -0000 [thread overview]
Message-ID: <877gqhf2uk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1350301607-16574-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Mon, 15 Oct 2012 19:46:47 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
No comment on the patch, just a question
Yao> - setup_kfail_for_target gdb/12798 "x86_64-*-*"
I didn't know this proc, so I looked it up:
proc setup_kfail_for_target { PR target } {
if { [istarget $target] } {
setup_kfail $PR $target
}
}
But setup_kfail itself just does:
proc setup_kfail { args } {
[...]
if {[istarget $sub_arg]} {
set kfail_flag 1
continue
}
So I don't understand how setup_kfail_for_target is different.
If I'm missing something, I'd like to know what.
Otherwise I think we can nuke this proc entirely.
Tom
next prev parent reply other threads:[~2012-10-23 18:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 11:46 Yao Qi
2012-10-23 6:59 ` ping: " Yao Qi
2012-10-23 8:36 ` Mark Kettenis
2012-10-23 10:06 ` Yao Qi
2012-10-23 18:22 ` Mark Kettenis
2012-10-24 7:45 ` Yao Qi
2012-10-23 18:41 ` Tom Tromey [this message]
2012-10-24 7:43 ` Yao Qi
2012-10-24 14:56 ` Tom Tromey
2012-10-25 14:55 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gqhf2uk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox