From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Fix kfail in gdb.base/callfuncs.exp
Date: Mon, 15 Oct 2012 11:46:00 -0000 [thread overview]
Message-ID: <1350301607-16574-1-git-send-email-yao@codesourcery.com> (raw)
Hi,
I find some tests in gdb.base/callfuncs.exp are not KFAIL'ed properly
in some configurations. For native gdb configured as
'x86_64-unknown-linux-gnu',
$make check RUNTESTFLAGS='CC_FOR_TARGET=i686-pc-linux-gnu-gcc --target_board=unix/-m32 callfuncs.exp'
KPASS: gdb.base/callfuncs.exp: p t_float_complex_values(fc1, fc2) (PRMS gdb/12798)
KPASS: gdb.base/callfuncs.exp: p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4) (PRMS gdb/12800)
KPASS: gdb.base/callfuncs.exp: p t_double_complex_values(dc1, dc2) (PRMS gdb/12798)
KPASS: gdb.base/callfuncs.exp: p t_double_complex_many_args(dc1, dc2,dc3, dc4, dc1, dc2, dc3, dc4, dc1, dc2, dc3, dc4, dc1, dc2, dc3, dc4) (PRMS gdb/12800)
KPASS: gdb.base/callfuncs.exp: call inferior func with struct - returns float _Complex (PRMS gdb/12796)
For native gdb configured as 'i686-pc-linux-gnu'
$ make check RUNTESTFLAGS='--target_board=native-gdbserver/-m64 callfuncs.exp'
FAIL: gdb.base/callfuncs.exp: p t_float_complex_values(fc1, fc2)
FAIL: gdb.base/callfuncs.exp: p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4)
FAIL: gdb.base/callfuncs.exp: p t_double_complex_values(dc1, dc2)
FAIL: gdb.base/callfuncs.exp: p t_double_complex_many_args(dc1, dc2, dc3, dc4, dc1, dc2, dc3, dc4, dc1, dc2, dc3, dc4, dc1, dc2, dc3, dc4)
FAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns float _Complex
The tests are known to fail only on 64-bit, so this patch below fixes
these KPASS or FAIL. OK to apply?
gdb/testsuite:
2012-10-15 Yao Qi <yao@codesourcery.com>
* gdb.base/callfuncs.exp (do_function_calls): KFAIL some test
for x86 with -m64.
---
gdb/testsuite/gdb.base/callfuncs.exp | 30 ++++++++++++++++++++++++------
1 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp
index f56761e..fe9dd1f 100644
--- a/gdb/testsuite/gdb.base/callfuncs.exp
+++ b/gdb/testsuite/gdb.base/callfuncs.exp
@@ -149,19 +149,34 @@ proc do_function_calls {} {
}
if [support_complex_tests] {
- setup_kfail_for_target gdb/12798 "x86_64-*-*"
+ # x86-64 or x86 with -m64.
+ if { ([istarget "x86_64-*-*"] || [istarget "i\[34567\]86-*-*"])
+ && [is_lp64_target] } {
+ setup_kfail gdb/12798 "*-*-*"
+ }
gdb_test "p t_float_complex_values(fc1, fc2)" " = 1"
gdb_test "p t_float_complex_values(fc3, fc4)" " = 0"
- setup_kfail_for_target gdb/12800 "x86_64-*-*"
+ # x86-64 or x86 with -m64.
+ if { ([istarget "x86_64-*-*"] || [istarget "i\[34567\]86-*-*"])
+ && [is_lp64_target] } {
+ setup_kfail gdb/12800 "*-*-*"
+ }
gdb_test "p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4)" " = 1"
gdb_test "p t_float_complex_many_args(fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1, fc1)" " = 0"
- setup_kfail_for_target gdb/12798 "x86_64-*-*"
+ # x86-64 or x86 with -m64.
+ if { ([istarget "x86_64-*-*"] || [istarget "i\[34567\]86-*-*"])
+ && [is_lp64_target] } {
+ setup_kfail gdb/12798 "*-*-*"
+ }
gdb_test "p t_double_complex_values(dc1, dc2)" " = 1"
gdb_test "p t_double_complex_values(dc3, dc4)" " = 0"
- setup_kfail_for_target gdb/12800 "x86_64-*-*"
+ if { ([istarget "x86_64-*-*"] || [istarget "i\[34567\]86-*-*"])
+ && [is_lp64_target] } {
+ setup_kfail gdb/12800 "*-*-*"
+ }
gdb_test "p t_double_complex_many_args(dc1, dc2, dc3, dc4, dc1, dc2, dc3, dc4, dc1, dc2, dc3, dc4, dc1, dc2, dc3, dc4)" " = 1"
gdb_test "p t_double_complex_many_args(dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1, dc1)" " = 0"
@@ -245,8 +260,11 @@ proc do_function_calls {} {
}
if [support_complex_tests] {
-
- setup_kfail_for_target gdb/12796 "x86_64-*-*"
+ # x86-64 or x86 with -m64.
+ if { ([istarget "x86_64-*-*"] || [istarget "i\[34567\]86-*-*"])
+ && [is_lp64_target] } {
+ setup_kfail gdb/12796 "*-*-*"
+ }
gdb_test "p t_structs_fc(struct_val1)" ".*= 3 \\+ 3 \\* I" \
"call inferior func with struct - returns float _Complex"
--
1.7.7.6
next reply other threads:[~2012-10-15 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 11:46 Yao Qi [this message]
2012-10-23 6:59 ` ping: " Yao Qi
2012-10-23 8:36 ` Mark Kettenis
2012-10-23 10:06 ` Yao Qi
2012-10-23 18:22 ` Mark Kettenis
2012-10-24 7:45 ` Yao Qi
2012-10-23 18:41 ` Tom Tromey
2012-10-24 7:43 ` Yao Qi
2012-10-24 14:56 ` Tom Tromey
2012-10-25 14:55 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350301607-16574-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox