From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95419-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20706 invoked by alias); 23 Oct 2012 18:41:32 -0000
Received: (qmail 20687 invoked by uid 22791); 23 Oct 2012 18:41:30 -0000
X-SWARE-Spam-Status: No, hits=-7.0 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Oct 2012 18:41:27 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9NIfPve026319	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 23 Oct 2012 14:41:25 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9NIfNB4017416	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 23 Oct 2012 14:41:24 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix kfail in gdb.base/callfuncs.exp
References: <1350301607-16574-1-git-send-email-yao@codesourcery.com>
Date: Tue, 23 Oct 2012 18:41:00 -0000
In-Reply-To: <1350301607-16574-1-git-send-email-yao@codesourcery.com> (Yao	Qi's message of "Mon, 15 Oct 2012 19:46:47 +0800")
Message-ID: <877gqhf2uk.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-10/txt/msg00427.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

No comment on the patch, just a question

Yao> -	setup_kfail_for_target gdb/12798 "x86_64-*-*"

I didn't know this proc, so I looked it up:

proc setup_kfail_for_target { PR target } {
    if { [istarget $target] } {
	setup_kfail $PR $target
    }
}

But setup_kfail itself just does:

proc setup_kfail { args } {
[...]
	if {[istarget $sub_arg]} {
	    set kfail_flag 1
	    continue
	}

So I don't understand how setup_kfail_for_target is different.
If I'm missing something, I'd like to know what.
Otherwise I think we can nuke this proc entirely.

Tom