Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Mike Frysinger <vapier@gentoo.org>,
	       Anthony Green <green@moxielogic.com>
Subject: Re: [commit] Adapt sim to new version number & date locations.
Date: Tue, 25 Jun 2013 15:28:00 -0000	[thread overview]
Message-ID: <877ghitdlm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1372117546-1639-1-git-send-email-brobecker@adacore.com> (Joel	Brobecker's message of "Mon, 24 Jun 2013 16:45:46 -0700")

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> The common and ppc parts were easy to fix, by just doing a reduced
Joel> version of what we do for GDB and GDBserver. Moxie, on the other
Joel> hand, needs the version info for different reasons, and I prefered
Joel> not touching it.

I looked at this a bit.

Right now the code there is a bit broken.  If you update your source
tree, rebuild, and reinstall, then you can end up in a situation where
the moxie sim reads an outdated moxie-gdb.dtb file.

This can happen due to missing dependencies: the version number is built
into the sim via a -D option, but interp.o doesn't depend on the version
file.

I think that since we don't generally support versioned installs in gdb,
it is simplest to just drop the version number here.  This fixes the bug
and also avoids using gdb's version.in.

Ok?

Tom

2013-06-25  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (dtbdir): Don't use gdb's version.in.

diff --git a/sim/moxie/Makefile.in b/sim/moxie/Makefile.in
index 884d277..3be637b 100644
--- a/sim/moxie/Makefile.in
+++ b/sim/moxie/Makefile.in
@@ -17,7 +17,7 @@
 
 ## COMMON_PRE_CONFIG_FRAG
 
-dtbdir = @datadir@/gdb-`sed q ${srcdir}/../../gdb/version.in`/dtb
+dtbdir = @datadir@/gdb/dtb
 
 SIM_OBJS = interp.o sim-load.o sim-io.o sim-config.o sim-utils.o	\
 sim-options.o sim-module.o sim-core.o sim-endian.o sim-trace.o 	\


  parent reply	other threads:[~2013-06-25 15:27 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21 17:33 [PATCH v5] don't keep a gdb-specific date Tom Tromey
2013-06-21 18:00 ` Pedro Alves
2013-06-24 14:56 ` Tom Tromey
2013-06-24 19:22   ` Joel Brobecker
2013-06-24 22:41   ` [commit] Fix host_name and target_name generation by common/create-version.sh Joel Brobecker
2013-06-24 22:59   ` [PATCH v5] don't keep a gdb-specific date Joel Brobecker
2013-06-24 23:58     ` [commit] Adapt sim to new version number & date locations Joel Brobecker
2013-06-25  0:52       ` Mike Frysinger
2013-06-25  1:53         ` Joel Brobecker
2013-06-25 15:51           ` Tom Tromey
2013-06-25 15:57             ` Tom Tromey
2013-06-25 15:46         ` Tom Tromey
2013-06-25 16:01           ` Eli Zaretskii
2013-06-25 15:28       ` Tom Tromey [this message]
2013-06-25 16:41         ` Mike Frysinger
2013-06-25  1:08     ` [PATCH v5] don't keep a gdb-specific date Hans-Peter Nilsson
2013-06-25 14:16       ` Tom Tromey
2013-06-25 14:25         ` Joel Brobecker
2013-06-25 14:43           ` Tom Tromey
2013-06-25 15:27             ` Tom Tromey
2013-06-26 11:23               ` sim checkout broken (was: [PATCH v5] don't keep a gdb-specific date) Hans-Peter Nilsson
2013-06-26 16:52                 ` sim checkout broken Tom Tromey
2013-06-26 17:58                   ` Hans-Peter Nilsson
2013-06-27  3:22                     ` Tom Tromey
2013-06-27  4:05                       ` Hans-Peter Nilsson
2013-06-27 15:22                         ` Tom Tromey
2013-06-27 16:30                           ` Tom Tromey
2013-06-27 17:09                             ` RFC: move common/version.in to gdb/ (Was: sim checkout broken) Tom Tromey
2013-06-28  3:18                               ` Hans-Peter Nilsson
2013-06-28 18:17                                 ` RFC: move common/version.in to gdb/ Tom Tromey
2013-06-27 17:27                             ` sim checkout broken Hans-Peter Nilsson
2013-06-27  8:19                       ` Andreas Schwab
2013-06-25 14:50         ` [PATCH v5] don't keep a gdb-specific date Pedro Alves
2013-06-25 14:53           ` Joel Brobecker
2013-06-25 15:01           ` Tom Tromey
2013-06-25 15:14             ` Pedro Alves
2013-06-26  2:45 ` Yao Qi
2013-06-26 16:06   ` Tom Tromey
2013-06-27  2:11     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ghitdlm.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=green@moxielogic.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox