From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22107 invoked by alias); 25 Jun 2013 15:27:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22098 invoked by uid 89); 25 Jun 2013 15:27:43 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 25 Jun 2013 15:27:43 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PFRZEh002574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 11:27:35 -0400 Received: from barimba (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5PFRXjm024583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 25 Jun 2013 11:27:34 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org, Mike Frysinger , Anthony Green Subject: Re: [commit] Adapt sim to new version number & date locations. References: <20130624224138.GC5326@adacore.com> <1372117546-1639-1-git-send-email-brobecker@adacore.com> Date: Tue, 25 Jun 2013 15:28:00 -0000 In-Reply-To: <1372117546-1639-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Mon, 24 Jun 2013 16:45:46 -0700") Message-ID: <877ghitdlm.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-06/txt/msg00711.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> The common and ppc parts were easy to fix, by just doing a reduced Joel> version of what we do for GDB and GDBserver. Moxie, on the other Joel> hand, needs the version info for different reasons, and I prefered Joel> not touching it. I looked at this a bit. Right now the code there is a bit broken. If you update your source tree, rebuild, and reinstall, then you can end up in a situation where the moxie sim reads an outdated moxie-gdb.dtb file. This can happen due to missing dependencies: the version number is built into the sim via a -D option, but interp.o doesn't depend on the version file. I think that since we don't generally support versioned installs in gdb, it is simplest to just drop the version number here. This fixes the bug and also avoids using gdb's version.in. Ok? Tom 2013-06-25 Tom Tromey * Makefile.in (dtbdir): Don't use gdb's version.in. diff --git a/sim/moxie/Makefile.in b/sim/moxie/Makefile.in index 884d277..3be637b 100644 --- a/sim/moxie/Makefile.in +++ b/sim/moxie/Makefile.in @@ -17,7 +17,7 @@ ## COMMON_PRE_CONFIG_FRAG -dtbdir = @datadir@/gdb-`sed q ${srcdir}/../../gdb/version.in`/dtb +dtbdir = @datadir@/gdb/dtb SIM_OBJS = interp.o sim-load.o sim-io.o sim-config.o sim-utils.o \ sim-options.o sim-module.o sim-core.o sim-endian.o sim-trace.o \