From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [commit] Fix host_name and target_name generation by common/create-version.sh.
Date: Mon, 24 Jun 2013 22:41:00 -0000 [thread overview]
Message-ID: <1372111549-26505-1-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <871u7rwodv.fsf@fleche.redhat.com>
Hello,
there was a small snafoo in this new script, which prevented the $host_alias
and $target_alias from being expanded during the generation of the
version.c file. As a result, the version info yields:
This GDB was configured as "--host=$host_alias --target=$target_alias".
^^^^^^^^^^^ ^^^^^^^^^^^^^
This patch fixes this issue.
gdb/ChangeLog:
* common/create-version.sh: Fix expansion of $host_alias
and $target_alias in generation of HOST_NAME and TARGET_NAME
(resp.).
Tested by rebuilding GDB native and cross on x86_64-linux.
Checked in.
---
gdb/ChangeLog | 6 ++++++
gdb/common/create-version.sh | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0b81e33..adaf463 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2013-06-24 Joel Brobecker <brobecker@adacore.com>
+
+ * common/create-version.sh: Fix expansion of $host_alias
+ and $target_alias in generation of HOST_NAME and TARGET_NAME
+ (resp.).
+
2013-06-24 Tom Tromey <tromey@redhat.com>
* common/create-version.sh: New file.
diff --git a/gdb/common/create-version.sh b/gdb/common/create-version.sh
index 2d2bc74..56871bf 100755
--- a/gdb/common/create-version.sh
+++ b/gdb/common/create-version.sh
@@ -32,7 +32,7 @@ date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$$/\1/p' $srcdir/../bfd/version.h`
sed -e "s/DATE/$date/" < $srcdir/common/version.in > version.tmp
echo '#include "version.h"' >> version.c-tmp
echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp
-echo 'const char host_name[] = "$host_alias";' >> version.c-tmp
-echo 'const char target_name[] = "$target_alias";' >> version.c-tmp
+echo 'const char host_name[] = "'"$host_alias"'";' >> version.c-tmp
+echo 'const char target_name[] = "'"$target_alias"'";' >> version.c-tmp
mv version.c-tmp $output
rm -f version.tmp
--
1.7.10.4
next prev parent reply other threads:[~2013-06-24 22:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 17:33 [PATCH v5] don't keep a gdb-specific date Tom Tromey
2013-06-21 18:00 ` Pedro Alves
2013-06-24 14:56 ` Tom Tromey
2013-06-24 19:22 ` Joel Brobecker
2013-06-24 22:41 ` Joel Brobecker [this message]
2013-06-24 22:59 ` Joel Brobecker
2013-06-24 23:58 ` [commit] Adapt sim to new version number & date locations Joel Brobecker
2013-06-25 0:52 ` Mike Frysinger
2013-06-25 1:53 ` Joel Brobecker
2013-06-25 15:51 ` Tom Tromey
2013-06-25 15:57 ` Tom Tromey
2013-06-25 15:46 ` Tom Tromey
2013-06-25 16:01 ` Eli Zaretskii
2013-06-25 15:28 ` Tom Tromey
2013-06-25 16:41 ` Mike Frysinger
2013-06-25 1:08 ` [PATCH v5] don't keep a gdb-specific date Hans-Peter Nilsson
2013-06-25 14:16 ` Tom Tromey
2013-06-25 14:25 ` Joel Brobecker
2013-06-25 14:43 ` Tom Tromey
2013-06-25 15:27 ` Tom Tromey
2013-06-26 11:23 ` sim checkout broken (was: [PATCH v5] don't keep a gdb-specific date) Hans-Peter Nilsson
2013-06-26 16:52 ` sim checkout broken Tom Tromey
2013-06-26 17:58 ` Hans-Peter Nilsson
2013-06-27 3:22 ` Tom Tromey
2013-06-27 4:05 ` Hans-Peter Nilsson
2013-06-27 15:22 ` Tom Tromey
2013-06-27 16:30 ` Tom Tromey
2013-06-27 17:09 ` RFC: move common/version.in to gdb/ (Was: sim checkout broken) Tom Tromey
2013-06-28 3:18 ` Hans-Peter Nilsson
2013-06-28 18:17 ` RFC: move common/version.in to gdb/ Tom Tromey
2013-06-27 17:27 ` sim checkout broken Hans-Peter Nilsson
2013-06-27 8:19 ` Andreas Schwab
2013-06-25 14:50 ` [PATCH v5] don't keep a gdb-specific date Pedro Alves
2013-06-25 14:53 ` Joel Brobecker
2013-06-25 15:01 ` Tom Tromey
2013-06-25 15:14 ` Pedro Alves
2013-06-26 2:45 ` Yao Qi
2013-06-26 16:06 ` Tom Tromey
2013-06-27 2:11 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372111549-26505-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox