Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] add -Wold-style-declaration
Date: Mon, 01 Jul 2013 19:49:00 -0000	[thread overview]
Message-ID: <877ghagiwe.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1371494572-26594-3-git-send-email-tromey@redhat.com> (Tom	Tromey's message of "Mon, 17 Jun 2013 12:42:51 -0600")

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> This adds -Wold-style-declaration to gdb's list of warnings.
Tom> It turns out that a few places use "const static" rather than
Tom> "static const".  The former is deprecated according to the C standard.

Tom> Tested by rebuilding with --enable-targets=all on x86-64 Fedora 18.
Tom> This misses most of the "nat" code, but any needed fixes are trivial.

Note that I grepped gdb for "const static" and did not find any more
hits.  So, probably nothing will be needed.

Tom


  reply	other threads:[~2013-07-01 19:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 18:42 [PATCH 0/3] add a few new warning options Tom Tromey
2013-06-17 18:42 ` [PATCH 1/3] add -Wmissing-parameter-type Tom Tromey
2013-06-17 18:42 ` [PATCH 2/3] add -Wold-style-declaration Tom Tromey
2013-07-01 19:49   ` Tom Tromey [this message]
2013-06-17 18:59 ` [PATCH 3/3] add -Wold-style-definition Tom Tromey
2013-07-02  8:08   ` Build regression on CentOS-5 [Re: [PATCH 3/3] add -Wold-style-definition] Jan Kratochvil
2013-07-02 20:53     ` Tom Tromey
2013-07-02 20:54       ` Tom Tromey
2013-07-03  9:00         ` Jan Kratochvil
2013-07-10 16:28           ` Tom Tromey
2013-07-10 16:51         ` Michael Eager
2013-07-10 18:11           ` Tom Tromey
2013-07-10 18:24             ` Joel Brobecker
2013-07-10 19:11               ` Michael Eager
2013-06-18  5:14 ` [PATCH 0/3] add a few new warning options Joel Brobecker
2013-07-01 19:46 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ghagiwe.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox