Re: Build regression on CentOS-5 [Re: [PATCH 3/3] add -Wold-style-definition]

[Tom Tromey <tromey@redhat.com>]

Jan> cc1: warnings being treated as errors
Jan> In file included from ada-exp.y:770:
Jan> ada-lex.c: In function 'yy_get_next_buffer':
Jan> ada-lex.c:1444: warning: old-style function definition
Jan> ada-lex.c: In function 'yy_get_previous_state':
Jan> ada-lex.c:1576: warning: old-style function definition

Thanks.

As much as I dislike working around old tools, how about the appended?

Tom

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index aca5dbf..a6a6c3e 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -165,6 +165,8 @@ GDB_WERROR_CFLAGS = $(WERROR_CFLAGS)
 
 GDB_WARN_CFLAGS_NO_FORMAT = `echo " $(GDB_WARN_CFLAGS) " \
 		   | sed "s/ -Wformat-nonliteral / -Wno-format-nonliteral /g"`
+GDB_WARN_CFLAGS_NO_DEFS = `echo " $(GDB_WARN_CFLAGS) " \
+		   | sed "s/ -Wold-style-definition / /g"`
 
 RDYNAMIC = @RDYNAMIC@
 
@@ -1580,6 +1582,17 @@ printcmd.o: $(srcdir)/printcmd.c
 		$(COMPILE.post) $(srcdir)/printcmd.c
 	$(POSTCOMPILE)
 
+# ada-exp.c can appear in srcdir, for releases; or in ., for
+# development builds.
+ADA_EXP_C = `if test -f ada-exp.c; then echo ada-exp.c; else echo $(srcdir)/ada-exp.c; fi`
+
+# Some versions of flex give output that triggers
+# -Wold-style-definition.
+ada-exp.o: ada-exp.c
+	$(COMPILE.pre) $(INTERNAL_CFLAGS) $(GDB_WARN_CFLAGS_NO_DEFS) \
+		$(COMPILE.post) $(ADA_EXP_C)
+	$(POSTCOMPILE)
+
 # Message files.  Based on code in gcc/Makefile.in.
 
 # Rules for generating translated message descriptions.  Disabled by