From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3298 invoked by alias); 1 Jul 2013 19:49:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3287 invoked by uid 89); 1 Jul 2013 19:49:40 -0000 X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Jul 2013 19:49:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r61JncXQ011416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Jul 2013 15:49:38 -0400 Received: from barimba (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r61JnbAj004201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 1 Jul 2013 15:49:38 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] add -Wold-style-declaration References: <1371494572-26594-1-git-send-email-tromey@redhat.com> <1371494572-26594-3-git-send-email-tromey@redhat.com> Date: Mon, 01 Jul 2013 19:49:00 -0000 In-Reply-To: <1371494572-26594-3-git-send-email-tromey@redhat.com> (Tom Tromey's message of "Mon, 17 Jun 2013 12:42:51 -0600") Message-ID: <877ghagiwe.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00061.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> This adds -Wold-style-declaration to gdb's list of warnings. Tom> It turns out that a few places use "const static" rather than Tom> "static const". The former is deprecated according to the C standard. Tom> Tested by rebuilding with --enable-targets=all on x86-64 Fedora 18. Tom> This misses most of the "nat" code, but any needed fixes are trivial. Note that I grepped gdb for "const static" and did not find any more hits. So, probably nothing will be needed. Tom