[buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943

[buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943

[Sergio Durigan Junior]

Hi,

Nick's commit:

  <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=85880250e591a51624d24db653aaace0c5ce5943;hp=fce10a8494efa8faec67b718f25e06d3d71694b3>

Introduced some regressions on GDB (they were caught by the BuildBot I
have running here, yay!).  I did not investigate them further yet, but I
thought it would be better to mention them here.  If nobody fixes this
soon, I intend to look at them tonight.

The regressions are all of the form:

  restore
  /home/buildbot/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/gdb.base/intstr1.tekhex
  '/home/buildbot/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/gdb.base/intstr1.tekhex' is not a recognized file format.
  (gdb) FAIL: gdb.base/dump.exp: struct as value, tekhex; file restored ok

On a side note, I can't find Nick's message mentioning the patch on the
binutils ml.

Cheers,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: [buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943

[Nicholas Clifton]

Hi Sergio,

> Nick's commit:

Thanks for reporting this.  I have fixed the bug with the patch below.

> On a side note, I can't find Nick's message mentioning the patch on the
> binutils ml.

That's because the message is in PR 17512, where a lot of the recent 
patches to minor file formats can be found.

Cheers
   Nick

bfd/ChangeLog

2015-01-09  Nick Clifton  <nickc@redhat.com>

	* tekhex.c (getvalue): Fix thinko in test for correct extraction
	of value.
	(getsym): Return false if there was not enough data to extract the
	symbol.

diff --git a/bfd/tekhex.c b/bfd/tekhex.c
index 9444117..94b4773 100644
--- a/bfd/tekhex.c
+++ b/bfd/tekhex.c
@@ -288,7 +288,7 @@ getvalue (char **srcp, bfd_vma *valuep, char * endp)

    *srcp = src;
    *valuep = value;
-  return len == 0;
+  return len == -1U;
  }

  static bfd_boolean
@@ -309,7 +309,7 @@ getsym (char *dstp, char **srcp, unsigned int *lenp, 
char * endp)
    dstp[i] = 0;
    *srcp = src + i;
    *lenp = len;
-  return TRUE;
+  return i == len;
  }

  static struct data_struct *

Re: [buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943

[Sergio Durigan Junior]

On Friday, January 09 2015, Nicholas Clifton wrote:

> Hi Sergio,
>
>> Nick's commit:
>
> Thanks for reporting this.  I have fixed the bug with the patch below.

Thanks for fixing this, Nick.  Buildbot will build this commit in a
moment and I will let you know if something shows up.

Cheers,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/