From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4402 invoked by alias); 9 Jan 2015 21:59:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4382 invoked by uid 89); 9 Jan 2015 21:59:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 09 Jan 2015 21:59:13 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t09Lx4fC010284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 9 Jan 2015 16:59:04 -0500 Received: from [10.36.6.10] (vpn1-6-10.ams2.redhat.com [10.36.6.10]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t09Lx2dK014038 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 9 Jan 2015 16:59:03 -0500 Message-ID: <54B04F25.6080206@redhat.com> Date: Fri, 09 Jan 2015 21:59:00 -0000 From: Nicholas Clifton User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sergio Durigan Junior , Binutils Development CC: GDB Patches Subject: Re: [buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943 References: <87h9w34nso.fsf@sergiodj.net> In-Reply-To: <87h9w34nso.fsf@sergiodj.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00237.txt.bz2 Hi Sergio, > Nick's commit: Thanks for reporting this. I have fixed the bug with the patch below. > On a side note, I can't find Nick's message mentioning the patch on the > binutils ml. That's because the message is in PR 17512, where a lot of the recent patches to minor file formats can be found. Cheers Nick bfd/ChangeLog 2015-01-09 Nick Clifton * tekhex.c (getvalue): Fix thinko in test for correct extraction of value. (getsym): Return false if there was not enough data to extract the symbol. diff --git a/bfd/tekhex.c b/bfd/tekhex.c index 9444117..94b4773 100644 --- a/bfd/tekhex.c +++ b/bfd/tekhex.c @@ -288,7 +288,7 @@ getvalue (char **srcp, bfd_vma *valuep, char * endp) *srcp = src; *valuep = value; - return len == 0; + return len == -1U; } static bfd_boolean @@ -309,7 +309,7 @@ getsym (char *dstp, char **srcp, unsigned int *lenp, char * endp) dstp[i] = 0; *srcp = src + i; *lenp = len; - return TRUE; + return i == len; } static struct data_struct *