Re: [PATCH V4 0/9] Add support for DTrace USDT probes to gdb

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Monday, February 02 2015, Jose E. Marchesi wrote:

> [Changes from V3:
> - Added some missing spaces after periods in the documentation patch.
>   Spotted by Eli.
> - Sort ChangeLog entries so they reflect the changes in the same order
>   than the diffs.
> - Use transformed tool names in the pdtrace script, which is now
>   processed through configure.  Introduce a new GDB_AC_TRANSFORM macro
>   to avoid repeating a code idiom and use it to define both
>   GDB_TRANSFORM_NAME and GCORE_TRANSFORM_NAME in the main
>   configure.ac.
> - Copyright year updated to 2015 in new files introduces by the patch
>   series.]

Thanks for the series, Jose!

The patches look pretty good.  I approved almost all of them.  The only
exception is the testcase patch, but not because of the testcase per se:
rather, it is because the new transform.m4 file that you added.  I think
we're 99% done on this.  Let's just wait to see what Pedro thinks about
the transform thing (since he was the one who requested it before).

I'm looking forward to seeing this series pushed.  Nice work!

Cheers,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/