Re: [PATCH V4 7/9] Simple testsuite for DTrace USDT probes.

[Pedro Alves <palves@redhat.com>]

On 02/17/2015 01:58 AM, Sergio Durigan Junior wrote:
> On Monday, February 16 2015, I wrote:
> 
>> On Monday, February 02 2015, Jose E. Marchesi wrote:
>>
>>> This patch adds some simple tests testing the support for DTrace USDT
>>> probes.  The testsuite will be skipped as unsupported in case the user
>>> does not have DTrace installed on her system.  The tests included in the
>>> test suite test breakpointing on DTrace probes, enabling and disabling
>>> probes, printing of probe arguments of several types and also
>>> breakpointing on several probes with the same name.
>>
>> Thanks again for this awesome testcase.  I don't have any more comments
>> to make about the patch itself; I personally liked your way of solving
>> the transform problem, though I have a preference to see those changes
>> in a different patch (i.e., not in the DTrace series).  Do you think you
>> can do that?  It should be really easy to extract this part from your
>> patch; and then, you'd only have to worry about the dtrace-side of it.
>>

If we don't do that, we'd need to duplicate the transform logic in
testsuite/configure.ac.  It's fine with me to add transform.m4 now, avoiding
the duplication.

>> I can't give you an approval for the transform.m4 thing, but for the
>> rest, you have an OK.
> 
> I forgot to add Pedro in the loop.  Pedro, do you have any comments
> about this?

It looks good to me as is.

Thanks,
Pedro Alves